Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file]

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task]

Specify task name only when it cannot be derived from the struct name. Only append to the default name.

Check failure on line 1 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file]

Provide mandatory file documentation.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -8,7 +8,7 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.
//

Check failure on line 11 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file]

Documentation for \author is missing, incorrect or misplaced.

Check failure on line 11 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file]

Documentation for \brief is missing, incorrect or misplaced.

Check failure on line 11 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file]

Documentation for \file is missing, incorrect or misplaced.
// ========================
//
// This code runs loop over ULS ee pars for virtual photon QC.
Expand All @@ -26,8 +26,8 @@
using namespace o2::framework::expressions;
using namespace o2::soa;

struct electronConverter5 {

Check failure on line 29 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/struct]

Use UpperCamelCase for names of structs.
Produces<aod::EMPrimaryElectrons_005> track_005;

Check failure on line 30 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/function-variable]

Use lowerCamelCase for names of functions and variables.

using MyElectrons002 = soa::Join<aod::EMPrimaryElectrons_002, aod::EMPrimaryElectronsCov_000>;
void process002to005(MyElectrons002 const& tracks)
Expand Down Expand Up @@ -119,8 +119,7 @@
}
PROCESS_SWITCH(electronConverter5, process003to005, "convert from 003 into 005", false);

using MyElectrons004 = soa::Join<aod::EMPrimaryElectrons_004, aod::EMPrimaryElectronsCov_000>;
void process004to005(MyElectrons004 const& tracks)
void process004to005(aod::EMPrimaryElectrons_004 const& tracks)
{
for (const auto& track : tracks) {
track_005(track.collisionId(),
Expand Down Expand Up @@ -167,5 +166,5 @@

WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{adaptAnalysisTask<electronConverter5>(cfgc, TaskName{"electron-converter5"})};

Check failure on line 169 in PWGEM/Dilepton/Tasks/Converters/electronConverter5.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task]

Specified task name electron-converter5 and the struct name electronConverter5 produce the same device name electron-converter5. TaskName is redundant.
}
Loading