[PWGLF] Nuspex: antineutron CEX table producer (clean PR) #13150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CMake; clang-format
FabiolaLP
requested review from
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
maciacco,
mpuccio,
romainschotter,
skundu692 and
smaff92
as code owners
|
O2 linter results: ❌ 12 errors, |
github-actions
bot
changed the title
maciacco
previously approved these changes
Sep 27, 2025
Collaborator
|
Thanks @FabiolaLP! Please have a look at the MegaLinter errors (missing |
Collaborator
|
Error while checking build/O2Physics/o2 for 3914fd1 at 2025-09-27 23:39: Full log here. |
auto-merge was automatically disabled
October 1, 2025 03:21
Head branch was pushed to by a user without write access
maciacco
previously approved these changes
Oct 1, 2025
Collaborator
|
@FabiolaLP thanks for the additional changes. I think you still have to check for a few errors concerning unused variables, see the error messages from the build tests |
Collaborator
|
Error while checking build/O2Physics/o2 for 49249fb at 2025-10-01 11:23: Full log here. |
Contributor
Author
|
Hi @maciacco, thanks for the approval. I will work on the linter comments. |
Collaborator
|
@maciacco Please do not leave PRs which do not pass required checks as "ready for review". |
vkucera
reviewed
Oct 5, 2025
maciacco
approved these changes
Oct 6, 2025
vkucera
reviewed
Oct 6, 2025
Comment on lines
+20
to
+32
| #include "CommonConstants/MathConstants.h" | ||
| #include "DCAFitter/DCAFitterN.h" | ||
| #include "DetectorsBase/Propagator.h" | ||
| #include "Framework/AnalysisDataModel.h" | ||
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/Logger.h" | ||
| #include "Framework/runDataProcessing.h" | ||
| #include "ReconstructionDataFormats/TrackParametrization.h" | ||
|
|
||
| #include "TMCProcess.h" | ||
| #include "TMath.h" | ||
| #include "TPDGCode.h" | ||
| #include "TVector3.h" |
Collaborator
There was a problem hiding this comment.
Not a blocker for this PR but please, in your next iteration, include all headers outside O2Physics using <>.
Contributor
Author
There was a problem hiding this comment.
Noted, thanks. I’ll use angle brackets for all headers outside O2Physics in the next pass.
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
ArkaprabhaSaha001
pushed a commit
to ArkaprabhaSaha001/O2Physics
that referenced
this pull request
Oct 21, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the final table producer and data model in the correct location, with minimal changes:
PWGLF/TableProducer/Nuspex/nucleiAntineutronCex.cxxPWGLF/DataModel/LFAntinCexTables.hPWGLF/TableProducer/Nuspex/CMakeLists.txtwith the workflow entryThis PR supersedes the previous one that included the initial/experimental task and its CMake changes. The old PR can be closed.