Skip to content

[PWGEM] Add Photonsphiv table #13127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhemmer-cern merged 3 commits into from
Oct 1, 2025
Merged

[PWGEM] Add Photonsphiv table #13127

mhemmer-cern merged 3 commits into from
Oct 1, 2025

Conversation

@ikantak
Copy link
Contributor

@ikantak ikantak commented Sep 25, 2025

Add photonsphiv with the variable PhiV as table and histogram to photonconversionbuild and gammatables for machine learning

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

O2 linter results: ❌ 185 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add Photonsohiv table [PWGEM] Add Photonsohiv table Sep 25, 2025
@alibuild alibuild mentioned this pull request Sep 25, 2025
Closed
@ikantak ikantak changed the title [PWGEM] Add Photonsohiv table [PWGEM] Add Photonsphiv table Sep 25, 2025
mhemmer-cern
mhemmer-cern previously approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@mhemmer-cern mhemmer-cern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mhemmer-cern
Copy link
Collaborator

mhemmer-cern commented Sep 25, 2025

Please merge the automatic PR made by alibuild to fix the formatting. Then we can merge this.

mhemmer-cern
mhemmer-cern reviewed Sep 26, 2025
View reviewed changes
PWGEM/PhotonMeson/DataModel/gammaTables.h Outdated
Comment on lines 416 to 417
DECLARE_SOA_INDEX_COLUMN(EMEvent, emevent); //!
DECLARE_SOA_COLUMN(PhiV, phiv, float); //!
Copy link
Collaborator

@mhemmer-cern mhemmer-cern Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentations here still need to go to pass the clang-format check.
We do not make indentations inside namespaces for some reason.

@mhemmer-cern
Copy link
Collaborator

mhemmer-cern commented Sep 26, 2025

To make it easier in the future I would highly recommend to install pre-commit hooks:
https://aliceo2group.github.io/analysis-framework/docs/tools/?highlight=clang-tidy#pre-commit-hooks
This way formatting like clang-format is checked locally when creating a commit and automatically corrected.

@dsekihat
Copy link
Collaborator

dsekihat commented Sep 29, 2025

Dear @ikantak , phiv is not defined because photon is massless particle. Namely, its opening angle is 0.

@mhemmer-cern mhemmer-cern enabled auto-merge (squash) October 1, 2025 06:50
@mhemmer-cern mhemmer-cern merged commit f2d8005 into AliceO2Group:master Oct 1, 2025
12 of 14 checks passed
@dsekihat
Copy link
Collaborator

dsekihat commented Oct 1, 2025

Dear @ikantak , @mhemmer-cern , phiv cannot be defined because photon is massless particle. Can you revert this PR?

jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
@ikantak @jmunozme
[PWGEM] Add Photonsphiv table (AliceO2Group#13127)
8790891 
Co-authored-by: Isabel Kantak <kantak@physi.uni-heidelberg.de>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@ikantak @jinhyunni
[PWGEM] Add Photonsphiv table (AliceO2Group#13127)
9563179 
Co-authored-by: Isabel Kantak <kantak@physi.uni-heidelberg.de>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@ikantak @ThePhDane
[PWGEM] Add Photonsphiv table (AliceO2Group#13127)
493a023 
Co-authored-by: Isabel Kantak <kantak@physi.uni-heidelberg.de>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@ikantak @jloemker
[PWGEM] Add Photonsphiv table (AliceO2Group#13127)
6bd7ad7 
Co-authored-by: Isabel Kantak <kantak@physi.uni-heidelberg.de>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@ikantak
[PWGEM] Add Photonsphiv table (AliceO2Group#13127)
666e370 
Co-authored-by: Isabel Kantak <kantak@physi.uni-heidelberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhemmer-cern mhemmer-cern mhemmer-cern approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@m-c-danisch m-c-danisch Awaiting requested review from m-c-danisch m-c-danisch is a code owner

@novitzky novitzky Awaiting requested review from novitzky novitzky is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Assignees

No one assigned

Labels

datamodel pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikantak @mhemmer-cern @dsekihat