Skip to content

[PWGCF] Minor fix and additional safeguards added #13108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
victor-gonzalez merged 4 commits into from
Sep 24, 2025
Merged

[PWGCF] Minor fix and additional safeguards added #13108

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5694b3a
[PWGCF] Minor fix and additional safeguards added
MaximVirta Sep 24, 2025
2b3ce02
[PWGCF] Run number setting moved after correction reading
MaximVirta Sep 24, 2025
5cadd47
Please consider the following formatting changes
alibuild Sep 24, 2025
0505fbd
Merge pull request #18 from alibuild/alibot-cleanup-13108
MaximVirta Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions PWGCF/JCorran/Tasks/jflucWeightsLoader.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ struct JflucWeightsLoader {
LOGF(fatal, "NUA correction weights file not found: %s", cfgPathPhiWeights.value.substr(8).c_str());
}
useNUAFromCCDB = false;
} else if (cfgPathPhiWeights.value == "") {
LOGF(info, "No NUA corrections provided.");
useNUAFromCCDB = false;
} else {
LOGF(info, "Assuming NUA corrections from CCDB.");
useNUAFromCCDB = true;
Expand All @@ -136,6 +139,9 @@ struct JflucWeightsLoader {
LOGF(info, "Loaded efficiency correction histogram locally.");
}
useEffFromCCDB = false;
} else if (cfgPathEffWeights.value == "") {
LOGF(info, "No efficiency corrections provided.");
useEffFromCCDB = false;
} else {
LOGF(info, "Assuming efficiency corrections from CCDB.");
useEffFromCCDB = true;
Expand Down Expand Up @@ -169,10 +175,9 @@ struct JflucWeightsLoader {
initCCDB(collision.runNumber(), timestamp, kNUA);
LOGF(info, "Loaded NUA correction histogram from CCDB for run %d.", collision.runNumber());
}
runNumber = collision.runNumber();
}
}
if (pfeff) {
if (pfeff || useEffFromCCDB) {
if (collision.runNumber() != runNumber) {
if (pheff)
delete pheff;
Expand All @@ -188,6 +193,10 @@ struct JflucWeightsLoader {
}
}
}

// Set run number after reading corrections
runNumber = collision.runNumber();

for (const auto& track : tracks) {
float phiWeight, effWeight;
if (ph) {
Expand Down
Loading