[DPG/Tasks/AOTTrack] Added the disableITSROFCut condition for event selection #13098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapalhares
requested review from
alibuild,
iouribelikov,
lbariogl,
mfaggin and
njacazio
as code owners
|
O2 linter results: ❌ 70 errors, |
github-actions
bot
changed the title
[DPG] Please consider the following formatting changes to AliceO2Group#13098
mfaggin
reviewed
Sep 25, 2025
DPG/Tasks/AOTTrack/qaMatchEff.cxx
Outdated
| LOGF(info, "Event selection not passed to ITSROFrame border, skipping..."); | ||
| return; | ||
| } | ||
| if (!collision.selection_bit(aod::evsel::kIsTriggerTVX) && !collision.selection_bit(aod::evsel::kNoTimeFrameBorder)) { |
Collaborator
There was a problem hiding this comment.
in all the pieces of code you add the check on the TF border cut also in this line, even if you check it already a few lines above... why? This looks wrong to me
…as a separate condition, alongside VtxTrigger and noTFBorder.
[DPG] Please consider the following formatting changes to AliceO2Group#13098
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.