[PWGCF] add generic pair tasks #13096

ariedel-cern · 2025-09-23T10:21:18Z

This PR adds generic pairs tasks to correlate pairs of tracks and pairs of tracks and v0 (=lambda and k0short) and surrounding infrastructure.

Additional fixes:

fix bug in dynamic columns for TPCTOF and TPCITS
additional safety checks in BaseSelection class
Add occupancy cuts to the collision bit mask

github-actions · 2025-09-23T10:21:34Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

alibuild

Auto-approving on behalf of @ariedel-cern.

victor-gonzalez · 2025-09-23T10:48:08Z

PWGCF/Femto/Core/closePairRejection.h

+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kAverage, HistTable), GetHistDesc(kAverage, HistTable), GetHistType(kAverage, HistTable), {specs.at(kAverage)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius0, HistTable), GetHistDesc(kRadius0, HistTable), GetHistType(kRadius0, HistTable), {specs.at(kRadius0)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius1, HistTable), GetHistDesc(kRadius1, HistTable), GetHistType(kRadius1, HistTable), {specs.at(kRadius1)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius2, HistTable), GetHistDesc(kRadius2, HistTable), GetHistType(kRadius2, HistTable), {specs.at(kRadius2)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius3, HistTable), GetHistDesc(kRadius3, HistTable), GetHistType(kRadius3, HistTable), {specs.at(kRadius3)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius4, HistTable), GetHistDesc(kRadius4, HistTable), GetHistType(kRadius4, HistTable), {specs.at(kRadius4)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius5, HistTable), GetHistDesc(kRadius5, HistTable), GetHistType(kRadius5, HistTable), {specs.at(kRadius5)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius6, HistTable), GetHistDesc(kRadius6, HistTable), GetHistType(kRadius6, HistTable), {specs.at(kRadius6)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius7, HistTable), GetHistDesc(kRadius7, HistTable), GetHistType(kRadius7, HistTable), {specs.at(kRadius7)});
+    mHistogramRegistry->add(std::string(prefix) + GetHistNamev2(kRadius8, HistTable), GetHistDesc(kRadius8, HistTable), GetHistType(kRadius8, HistTable), {specs.at(kRadius8)});


I guess a loop should work here

victor-gonzalez · 2025-09-23T10:48:42Z

PWGCF/Femto/Core/closePairRejection.h

+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kAverage, HistTable)), mDeta, mAverageDphistar);
+
+    // fill radii hists
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius0, HistTable)), mDeta, mDphistar.at(0));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius1, HistTable)), mDeta, mDphistar.at(1));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius2, HistTable)), mDeta, mDphistar.at(2));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius3, HistTable)), mDeta, mDphistar.at(3));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius4, HistTable)), mDeta, mDphistar.at(4));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius5, HistTable)), mDeta, mDphistar.at(5));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius6, HistTable)), mDeta, mDphistar.at(6));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius7, HistTable)), mDeta, mDphistar.at(7));
+    mHistogramRegistry->fill(HIST(prefix) + HIST(GetHistName(kRadius8, HistTable)), mDeta, mDphistar.at(8));


In here also

victor-gonzalez · 2025-09-23T10:54:15Z

PWGCF/Femto/Core/pairHistManager.h

+  kPt2VsKt,
+  kPt1VsMt,
+  kPt2VsMt,
+  kPairHistogramLast


It is a matter of taste but if you use it in a loop it is more readable to use kNoOfPairHistograms instead of kPairHistogramLast because Last is misleading as it is never used

victor-gonzalez · 2025-09-23T10:54:30Z

PWGCF/Femto/Core/pairHistManager.h

+  kVtxMult,
+  kVtxCent,
+  kVtxMultCent,
+  kMixingPolicyLast


victor-gonzalez · 2025-09-23T10:58:42Z

PWGCF/Femto/Core/pairHistManager.h

+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kKstar, HistTable), GetHistDesc(kKstar, HistTable), GetHistType(kKstar, HistTable), {Specs[kKstar]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kMt, HistTable), GetHistDesc(kMt, HistTable), GetHistType(kMt, HistTable), {Specs[kMt]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kPt1VsPt2, HistTable), GetHistDesc(kPt1VsPt2, HistTable), GetHistType(kPt1VsPt2, HistTable), {Specs[kPt1VsPt2]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kPt1VsKstar, HistTable), GetHistDesc(kPt1VsKstar, HistTable), GetHistType(kPt1VsKstar, HistTable), {Specs[kPt1VsKstar]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kPt2VsKstar, HistTable), GetHistDesc(kPt2VsKstar, HistTable), GetHistType(kPt2VsKstar, HistTable), {Specs[kPt2VsKstar]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kPt1VsKt, HistTable), GetHistDesc(kPt1VsKt, HistTable), GetHistType(kPt1VsKt, HistTable), {Specs[kPt1VsKt]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kPt2VsKt, HistTable), GetHistDesc(kPt2VsKt, HistTable), GetHistType(kPt2VsKt, HistTable), {Specs[kPt2VsKt]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kPt1VsMt, HistTable), GetHistDesc(kPt1VsMt, HistTable), GetHistType(kPt1VsMt, HistTable), {Specs[kPt1VsMt]});
+      mHistogramRegistry->add(analysisDir + GetHistNamev2(kPt2VsMt, HistTable), GetHistDesc(kPt2VsMt, HistTable), GetHistType(kPt2VsMt, HistTable), {Specs[kPt2VsMt]});


Would a loop also work here?

victor-gonzalez · 2025-09-23T11:02:25Z

PWGCF/Femto/Core/partitions.h

+    (femtobase::stored::eta < selection.etaMax) &&                                                                                                                                                        \
+    (femtobase::stored::phi > selection.phiMin) &&                                                                                                                                                        \
+    (femtobase::stored::phi < selection.phiMax) &&                                                                                                                                                        \
+    ifnode(nabs(femtobase::stored::signedPt) * (nexp(femtobase::stored::eta) + nexp(-1.f * femtobase::stored::eta)) / 2.f <= selection.pidThres, /* o2-linter: disable=magic-number (formula for cosh) */ \


Thanks for trying to fix the linter error
@vkucera any suggestion?

Comments inside macros are tricky. You can silence the error by wrapping the expression in parentheses.

I checked the o2 linter code and it only disables the warnings if there the comment is of the form //

I tried to silence the warning with /* // o2-linter ../ */ but then cpplint complains about the unusal comment style.

I am not sure if it is easily possible to have o2-linter check for both // and /* ... */ comments, though the case here is for sure an exception.
I already request for the implementation of cosh as a functions node so this line can be simplified hopefully in a the future

Comments inside macros are tricky. You can silence the error by wrapping the expression in parentheses.

You mean, wrapping the whole expression like this

(nabs(femtobase::stored::signedPt) * (nexp(femtobase::stored::eta) + nexp(-1.f * femtobase::stored::eta)) / 2.f <= selection.pidThres)

No, the / 2.f has to be inside the parentheses.

No, the / 2.f has to be inside the parentheses.

I see! Thanks!

victor-gonzalez

Fine from my side! Thanks!
I left a few comments in case you want to consider them. I'm not quite sure about the loops ones due to the HIST macro but have a look anyway

ariedel-cern · 2025-09-23T11:11:11Z

Thanks for the suggestions Victor. I will have a look at the next iteration and see if I can put the for loop there.

alibuild

Auto-approving on behalf of @ariedel-cern.

ariedel-cern added 3 commits September 22, 2025 09:00

Feat: general fixes

4a6f75a

Feat: add track-track and track-v0 pairing task

90cc905

Feat: add absolute charge as configurable

2d3ac1e

ariedel-cern requested review from alibuild, glromane, lauraser, lgraczykCern, otonvd, prchakra, shouqiye, victor-gonzalez and zchochul as code owners September 23, 2025 10:21

github-actions bot added pwgcf datamodel labels Sep 23, 2025

github-actions bot changed the title ~~PWGCF: add generic pair tasks~~ [PWGCF] add generic pair tasks Sep 23, 2025

ariedel-cern enabled auto-merge (squash) September 23, 2025 10:40

alibuild previously approved these changes Sep 23, 2025

View reviewed changes

Fix: fix histogram naming

ac2381c

ariedel-cern dismissed alibuild’s stale review via ac2381c September 23, 2025 10:42

victor-gonzalez reviewed Sep 23, 2025

View reviewed changes

PWGCF/Femto/Core/pairHistManager.h

kVtxMult,

kVtxCent,

kVtxMultCent,

kMixingPolicyLast

Copy link

Collaborator

victor-gonzalez Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

victor-gonzalez reviewed Sep 23, 2025

View reviewed changes

ariedel-cern disabled auto-merge September 23, 2025 10:59

victor-gonzalez reviewed Sep 23, 2025

View reviewed changes

ariedel-cern enabled auto-merge (squash) September 23, 2025 11:13

alibuild approved these changes Sep 23, 2025

View reviewed changes

ariedel-cern merged commit 2c3a7e7 into AliceO2Group:master Sep 23, 2025
24 of 26 checks passed

jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025

[PWGCF] add generic pair tasks (AliceO2Group#13096)

43a92a2

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025

[PWGCF] add generic pair tasks (AliceO2Group#13096)

38bf0a6

ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025

[PWGCF] add generic pair tasks (AliceO2Group#13096)

f0649f6

jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025

[PWGCF] add generic pair tasks (AliceO2Group#13096)

ad1be48

lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025

[PWGCF] add generic pair tasks (AliceO2Group#13096)

af5c79f

[PWGCF] add generic pair tasks #13096

[PWGCF] add generic pair tasks #13096

Uh oh!

Conversation

ariedel-cern commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez left a comment

Choose a reason for hiding this comment

Uh oh!

ariedel-cern commented Sep 23, 2025

Uh oh!

alibuild left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Sep 23, 2025 •

edited

Loading