-
Notifications
You must be signed in to change notification settings - Fork 613
[ALICE3] Update a3 geo in fasttracker #13042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jesgum
commented
Sep 19, 2025
- Update x0 values for inert layers
- Add iTOF & coldplate
- Apply scale to VD x0
- I'm not sure about the xrho values in this setup so they are left at 0 and I'll run with e-loss disabled for now as it has previously shown to have a minimal, if any, effect. Will update and add the values as soon as I have them
|
O2 linter results: ❌ 175 errors, |
Collaborator
|
Ciao @jesgum very good, many thanks! We should see that this gets taken from an external file fetched via the CCDB. As we approach the geometry configuration we want to change between geometries without touching the code. |
Collaborator
|
Also, the CI is complaining rightfully |
auto-merge was automatically disabled
September 19, 2025 11:17
Head branch was pushed to by a user without write access
njacazio
approved these changes
Sep 19, 2025
jmunozme
pushed a commit
to jmunozme/O2Physics
that referenced
this pull request
Oct 3, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.