Skip to content

[PWGHF] Improve skimming code #12998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkucera merged 14 commits into from
Sep 17, 2025
Merged

[PWGHF] Improve skimming code #12998

vkucera merged 14 commits into from
Sep 17, 2025

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Sep 16, 2025 •
edited
Loading

  • Fix types of bitmaps nCutStatus2ProngBit, nCutStatus3ProngBit, prong2CutStatus, prong3CutStatus.
  • Reduce unnecessary operations in applyPreselection2Prong, applyPreselection3Prong.
  • Use do3Prong as bool properly.
  • Improve const correctness.
  • Simplify array declarations using type deduction.
  • Fix array initialisations.
  • Fix UChar_t type for itsClusterMap.
  • Pass by const&.
  • Use auto more to capture return values.
  • Remove default template arguments of applyMlSelectionForHfFilters3Prong, run2And3Prongs.
  • Remove useless argument of getHfCollisionRejectionMaskWithUpc.
  • Define etaMinDefault to fix magic numbers.

@github-actions github-actions bot added the pwghf PWG-HF label Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 7 disabled

@github-actions github-actions bot changed the title Improve skimming code [PWGHF] Improve skimming code Sep 16, 2025
@vkucera vkucera marked this pull request as ready for review September 16, 2025 15:20
@vkucera vkucera enabled auto-merge (squash) September 17, 2025 11:26
alibuild
alibuild approved these changes Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

@vkucera vkucera merged commit 3cc06fd into AliceO2Group:master Sep 17, 2025
13 checks passed
@vkucera vkucera deleted the skims branch September 17, 2025 11:27
jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
@vkucera @jmunozme
[PWGHF] Improve skimming code (AliceO2Group#12998)
3d8b8f6
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@vkucera @jinhyunni
[PWGHF] Improve skimming code (AliceO2Group#12998)
d6bc547
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@vkucera @ThePhDane
[PWGHF] Improve skimming code (AliceO2Group#12998)
ff56b9e
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@vkucera @jloemker
[PWGHF] Improve skimming code (AliceO2Group#12998)
92257e5
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@vkucera
[PWGHF] Improve skimming code (AliceO2Group#12998)
8d59e3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vkucera @alibuild