Skip to content

[PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset #12991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolavick merged 30 commits into from
Sep 22, 2025
Merged

[PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset #12991

rolavick merged 30 commits into from
Sep 22, 2025

Conversation

@nivram-phy
Copy link
Contributor

@nivram-phy nivram-phy commented Sep 16, 2025

Basic task to create histograms and TTree on mass, pT, eta and phi

@github-actions github-actions bot added the pwgud label Sep 16, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title New Task : Incoherent JPsi Polarization with Run 3 Dataset [PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset Sep 16, 2025
@alibuild alibuild mentioned this pull request Sep 16, 2025
Closed
@nivram-phy nivram-phy marked this pull request as ready for review September 16, 2025 09:06
@rolavick
Copy link
Collaborator

rolavick commented Sep 17, 2025

Dear @nivram-phy,
before I approve, could you please solve the o2 linter errors for the new file + line 12 error from the cmakefile (the file-task name correspondance). Thank you.
Roman

@alibuild alibuild mentioned this pull request Sep 18, 2025
Merged
@alibuild alibuild mentioned this pull request Sep 18, 2025
Closed
@nivram-phy
Copy link
Contributor Author

nivram-phy commented Sep 18, 2025

Hello @rolavick,
I fixed most of the errors. But it looks like it expects a UpperCamelCase for the name. I have modified the name from upcPolarisationJPsiIncorr.cxx to upcPolarisationJpsiIncorr.cxx. But kept "upc" as is, similar to other codes in the tasks folder. Would you like that also changed to "Upc"?

@rolavick rolavick enabled auto-merge (squash) September 18, 2025 13:19
@alibuild
Copy link
Collaborator

alibuild commented Sep 18, 2025

Error while checking build/O2Physics/o2 for 29d2a8c at 2025-09-18 18:26:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

@rolavick rolavick disabled auto-merge September 18, 2025 18:43
rolavick
rolavick requested changes Sep 18, 2025
View reviewed changes
@nivram-phy nivram-phy requested a review from rolavick September 19, 2025 07:36
vkucera
vkucera reviewed Sep 19, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Sep 19, 2025

Error while checking build/O2Physics/o2 for fabc784 at 2025-09-19 13:49:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12991-slc9_x86-64/0/PWGUD/Tasks/upcPolarisationJpsiIncoh.cxx:235:35: error: unused parameter 'zdc' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Sep 19, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented Sep 20, 2025

Error while checking build/O2Physics/o2 for 3522c6d at 2025-09-20 13:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12991-slc9_x86-64/0/PWGUD/Tasks/upcPolarisationJpsiIncoh.cxx:20:10: fatal error: Common/PhysicsConstants.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

Niveditha Ramasubramanian added 2 commits September 20, 2025 16:45
@alibuild alibuild mentioned this pull request Sep 20, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Sep 21, 2025

Error while checking build/O2Physics/o2 for 3f80a34 at 2025-09-21 05:29:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12991-slc9_x86-64/0/PWGUD/Tasks/upcPolarisationJpsiIncoh.cxx:20:10: fatal error: Common/RecoDecay.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Sep 21, 2025
Closed
@rolavick rolavick merged commit 6de6c7d into AliceO2Group:master Sep 22, 2025
11 of 12 checks passed
jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
@nivram-phy @alibuild @jmunozme
[PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset (A…
af20541 
…liceO2Group#12991)

Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyodhc11.in2p3.fr>
Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyoalice02.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@nivram-phy @alibuild @jinhyunni
[PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset (A…
17a7f8a 
…liceO2Group#12991)

Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyodhc11.in2p3.fr>
Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyoalice02.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@nivram-phy @alibuild @ThePhDane
[PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset (A…
92f904d 
…liceO2Group#12991)

Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyodhc11.in2p3.fr>
Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyoalice02.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@nivram-phy @alibuild @jloemker
[PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset (A…
a8c52e4 
…liceO2Group#12991)

Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyodhc11.in2p3.fr>
Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyoalice02.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@nivram-phy @alibuild
[PWGUD] New Task : Incoherent JPsi Polarization with Run 3 Dataset (A…
043e186 
…liceO2Group#12991)

Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyodhc11.in2p3.fr>
Co-authored-by: Niveditha Ramasubramanian <nramasubramanian@lyoalice02.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@rolavick rolavick rolavick approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler

Assignees

No one assigned

Labels

pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nivram-phy @rolavick @alibuild @vkucera