Skip to content

[PWGLF] Very minor cleanup of printouts #12979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainschotter merged 2 commits into from
Sep 14, 2025
Merged

[PWGLF] Very minor cleanup of printouts #12979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316ff89
Move LOGF to debug to suppress unnecessary printouts
ddobrigk Sep 14, 2025
a3ab1f4
Move LOGF to debug to suppress output
ddobrigk Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PWGLF/Utils/strangenessBuilderHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
}
v0tableGrouped.push_back(thisV0); // publish last

LOGF(info, "Duplicate V0s grouped. aod::V0s counted: %i, unique index pairs: %i", V0s.size(), v0tableGrouped.size());
LOGF(debug, "Duplicate V0s grouped. aod::V0s counted: %i, unique index pairs: %i", V0s.size(), v0tableGrouped.size());
return v0tableGrouped;
}

Expand Down Expand Up @@ -366,14 +366,14 @@
negativeTrackParam.getPxPyPzGlo(v0.negativeMomentum);
positiveTrackParam.getXYZGlo(v0.positivePosition);
negativeTrackParam.getXYZGlo(v0.negativePosition);
for (int i = 0; i < 3; i++) {

Check failure on line 369 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
// avoids misuse if mixed with KF particle use
v0.momentum[i] = v0.positiveMomentum[i] + v0.negativeMomentum[i];
}

// get decay vertex coordinates
const auto& vtx = fitter.getPCACandidate();
for (int i = 0; i < 3; i++) {

Check failure on line 376 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
v0.position[i] = vtx[i];
}

Expand All @@ -384,7 +384,7 @@
}
}

v0.daughterDCA = TMath::Sqrt(fitter.getChi2AtPCACandidate());

Check failure on line 387 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.

if constexpr (useSelections) {
if (v0.daughterDCA > v0selections.dcav0dau) {
Expand All @@ -404,7 +404,7 @@
}
}

v0.pointingAngle = TMath::ACos(cosPA);

Check failure on line 407 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
v0.dcaToPV = CalculateDCAStraightToPV(
v0.position[0], v0.position[1], v0.position[2],
v0.positiveMomentum[0] + v0.negativeMomentum[0],
Expand Down Expand Up @@ -446,7 +446,7 @@
positiveTrackParam.getCovXYZPxPyPzGlo(covTpositive);
negativeTrackParam.getCovXYZPxPyPzGlo(covTnegative);
constexpr int MomInd[6] = {9, 13, 14, 18, 19, 20}; // cov matrix elements for momentum component
for (int i = 0; i < 6; i++) {

Check failure on line 449 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
v0.momentumCovariance[i] = covTpositive[MomInd[i]] + covTnegative[MomInd[i]];
}
}
Expand Down Expand Up @@ -586,7 +586,7 @@
v0 = {};
return false;
}
v0.pointingAngle = TMath::ACos(cosPA);

Check failure on line 589 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.

v0.dcaToPV = CalculateDCAStraightToPV(
v0.position[0], v0.position[1], v0.position[2],
Expand Down Expand Up @@ -771,7 +771,7 @@
lBachelorTrack = fitter.getTrack(1);

// DCA between cascade daughters
cascade.cascadeDaughterDCA = TMath::Sqrt(fitter.getChi2AtPCACandidate());

Check failure on line 774 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
if (cascade.cascadeDaughterDCA > cascadeselections.dcacascdau) {
cascade = {};
return false;
Expand All @@ -798,7 +798,7 @@
cascade = {};
return false;
}
cascade.pointingAngle = TMath::ACos(cosPA);

Check failure on line 801 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.

// Calculate DCAxy of the cascade (with bending)
auto lCascadeTrack = fitter.createParentTrackParCov();
Expand Down Expand Up @@ -996,7 +996,7 @@
return false;
}
// save classical DCA daughters
cascade.v0DaughterDCA = TMath::Sqrt(fitter.getChi2AtPCACandidate());

Check failure on line 999 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.

// re-acquire from DCA fitter
posTrackParCov = fitter.getTrack(0);
Expand Down Expand Up @@ -1175,7 +1175,7 @@
cascade = {};
return false;
}
cascade.pointingAngle = TMath::ACos(cosPA);

Check failure on line 1178 in PWGLF/Utils/strangenessBuilderHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.

// Calculate masses a priori
float MLambda, SigmaLambda, MXi, SigmaXi, MOmega, SigmaOmega;
Expand Down
2 changes: 1 addition & 1 deletion PWGLF/Utils/strangenessBuilderModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,7 +1278,7 @@ class BuilderModule
sorted_cascade = sort_indices(cascadeList, (baseOpts.mc_findableMode.value > 0));
}

LOGF(info, "AO2D input: %i V0s, %i cascades. Building list sizes: %i V0s, %i cascades", v0s.size(), cascades.size(), v0List.size(), cascadeList.size());
LOGF(debug, "AO2D input: %i V0s, %i cascades. Building list sizes: %i V0s, %i cascades", v0s.size(), cascades.size(), v0List.size(), cascadeList.size());
}

//__________________________________________________
Expand Down
Loading