Skip to content

[PWGHF] Added multiplicity in efficiency correction #12939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 9 commits into from
Sep 23, 2025
Merged

[PWGHF] Added multiplicity in efficiency correction #12939

fgrosa merged 9 commits into from
Sep 23, 2025

Conversation

@scattaru
Copy link
Contributor

@scattaru scattaru commented Sep 10, 2025

Dear all,
In this PR I have added the multiplicity in the efficiency correction as well as fixed some issues in the PID processes.

Cheers,
Samuele

@scattaru scattaru marked this pull request as draft September 10, 2025 11:59
@github-actions
Copy link

github-actions bot commented Sep 10, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Added multiplicity in efficiency correction [PWGHF] Added multiplicity in efficiency correction Sep 10, 2025
vkucera
vkucera reviewed Sep 10, 2025
View reviewed changes
vkucera
vkucera reviewed Sep 10, 2025
View reviewed changes
PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx
Comment on lines -376 to +432
registry.fill(HIST("hMassDsVsPt"), massD, ptD, efficiencyWeightD);
registry.fill(HIST("hMassDsVsPt"), massD, std::abs(ptD), efficiencyWeightD);
Copy link
Collaborator

@vkucera vkucera Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can ptD be negative?

Copy link
Contributor Author

@scattaru scattaru Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because to separate positive and negative tracks in the correlator the pt of D meson candidates and associated particles is multiplied by the charge of the particle. This is done in order to not add another column to the table and be able to compute correlations Ds+ - K+ (LS) and Ds+ - K- (ULS)

Copy link
Collaborator

@vkucera vkucera Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Well, the name is quite misleading. Just my impression.

Copy link
Collaborator

@fgrosa fgrosa Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not used in already produced derived data, you can consider to rename it signedPt or something similar. If in already produced derived data instead I would keep it as it is, to avoid unnecessary complications. For the rest the PR looks good to me!

vkucera
vkucera reviewed Sep 10, 2025
View reviewed changes
@scattaru scattaru marked this pull request as ready for review September 11, 2025 09:04
@alibuild
Copy link
Collaborator

alibuild commented Sep 11, 2025

Error while checking build/O2Physics/o2 for 1ca8b2c at 2025-09-11 11:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorDsHadronsReduced.cxx:144:31: error: expected ')' before 'collision'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorDsHadronsReduced.cxx:139:28: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<2447366410>, o2::aod::Hash<499520824>, o2::aod::Hash<2286545062> > >) (double, float, const float&, const float&, int&)'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorDsHadronsReduced.cxx:207:29: error: expected ')' before 'c1'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorDsHadronsReduced.cxx:202:26: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<2447366410>, o2::aod::Hash<499520824>, o2::aod::Hash<2286545062> > >) (double, float, const float&, const float&, int&)'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:354:80: error: cannot convert 'std::optional<int>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:357:90: error: cannot convert 'std::optional<int>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:376:128: error: cannot convert 'std::optional<float>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:379:95: error: cannot convert 'std::optional<int>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:379:220: error: cannot convert 'std::optional<float>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:381:107: error: cannot convert 'std::optional<int>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:384:91: error: cannot convert 'std::optional<int>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:384:195: error: cannot convert 'std::optional<int>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:465:99: error: cannot convert 'HfTaskCorrelationDsHadrons::EfficiencyMode' to 'std::optional<float>'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:586:99: error: cannot convert 'HfTaskCorrelationDsHadrons::EfficiencyMode' to 'std::optional<float>'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:683:99: error: cannot convert 'HfTaskCorrelationDsHadrons::EfficiencyMode' to 'std::optional<float>'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:755:99: error: cannot convert 'HfTaskCorrelationDsHadrons::EfficiencyMode' to 'std::optional<float>'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:844:99: error: cannot convert 'HfTaskCorrelationDsHadrons::EfficiencyMode' to 'std::optional<float>'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Sep 11, 2025
Merged
@scattaru
Merge pull request #22 from alibuild/alibot-cleanup-12939
8bde7bb 
Please consider the following formatting changes to AliceO2Group#12939
@alibuild
Copy link
Collaborator

alibuild commented Sep 11, 2025 •
edited
Loading

Error while checking build/O2Physics/o2 for 8bde7bb at 2025-09-13 06:51:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:354:80: error: invalid 'static_cast' from type 'std::optional<int>' to type 'double'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:357:90: error: invalid 'static_cast' from type 'std::optional<int>' to type 'double'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:376:128: error: cannot convert 'std::optional<float>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:379:95: error: invalid 'static_cast' from type 'std::optional<int>' to type 'double'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:379:241: error: cannot convert 'std::optional<float>' to 'Double_t' {aka 'double'}
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:381:107: error: invalid 'static_cast' from type 'std::optional<int>' to type 'double'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:384:91: error: invalid 'static_cast' from type 'std::optional<int>' to type 'double'
/sw/SOURCES/O2Physics/12939-slc9_x86-64/0/PWGHF/HFC/Tasks/taskCorrelationDsHadrons.cxx:384:216: error: invalid 'static_cast' from type 'std::optional<int>' to type 'double'
ninja: build stopped: subcommand failed.

Full log here.

@fgrosa fgrosa enabled auto-merge (squash) September 23, 2025 15:24
@fgrosa fgrosa merged commit 6dd5396 into AliceO2Group:master Sep 23, 2025
13 checks passed
@scattaru scattaru deleted the DsBranchSE branch September 24, 2025 12:32
jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
@scattaru @alibuild @jmunozme
[PWGHF] Added multiplicity in efficiency correction (AliceO2Group#12939)
87eb40e 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@scattaru @alibuild @jinhyunni
[PWGHF] Added multiplicity in efficiency correction (AliceO2Group#12939)
e9cf464 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@scattaru @alibuild @ThePhDane
[PWGHF] Added multiplicity in efficiency correction (AliceO2Group#12939)
7f782a9 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@scattaru @alibuild @jloemker
[PWGHF] Added multiplicity in efficiency correction (AliceO2Group#12939)
0aca1cb 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@scattaru @alibuild
[PWGHF] Added multiplicity in efficiency correction (AliceO2Group#12939)
6c0678f 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@fgrosa fgrosa fgrosa approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scattaru @alibuild @fgrosa @vkucera