Skip to content

[DPG] Add new histograms for track contributions and chi2 #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 2 commits into from
Sep 12, 2025
Merged

[DPG] Add new histograms for track contributions and chi2 #12930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15ca469
Add new histograms for track contributions and chi2
njacazio Sep 9, 2025
74a2410
Remove continue statement for ITS tracks
njacazio Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions DPG/Tasks/AOTTrack/qaEventTrack.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@
// TODO: ask if one can have different filters for both process functions
Filter trackFilter = (trackSelection.node() == 0) ||
((trackSelection.node() == 1) && requireGlobalTrackInFilter()) ||
((trackSelection.node() == 2) && requireGlobalTrackWoPtEtaInFilter()) ||

Check failure on line 118 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
((trackSelection.node() == 3) && requireGlobalTrackWoDCAInFilter()) ||

Check failure on line 119 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
((trackSelection.node() == 4) && requireQualityTracksInFilter()) ||
((trackSelection.node() == 5) && requireTrackCutInFilter(TrackSelectionFlags::kInAcceptanceTracks)) ||
((trackSelection.node() == 6) && requireGlobalTrackWoTPCClusterInFilter()) ||
Expand Down Expand Up @@ -205,7 +205,7 @@
const AxisSpec axisInvPt{binsInvPt, "1/#it{p}_{T, gen} [GeV/c]^{-1}"};
const AxisSpec axisSigned1Pt{binsSigned1Pt, "Q/#it{p}_{T, gen} [GeV/c]^{-1}"};
const AxisSpec axisEta{180, -0.9, 0.9, "#it{#eta}"};
const AxisSpec axisPhi{180, 0., 2 * M_PI, "#it{#varphi} [rad]"};

Check failure on line 208 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pi-multiple-fraction] 

Use multiples/fractions of PI defined in o2::constants::math.

Check failure on line 208 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[external-pi] 

Use the PI constant (and its multiples and fractions) defined in o2::constants::math.
const AxisSpec axisVertexNumContrib{(overwriteAxisRangeForPbPb ? vecBinsVertexNumContribDefaultPbPb : vecBinsVertexNumContrib), "Number Of contributors to the PV"};
const AxisSpec axisVertexPosX{binsVertexPosXY, "X [cm]"};
const AxisSpec axisVertexPosY{binsVertexPosXY, "Y [cm]"};
Expand All @@ -216,7 +216,7 @@
const AxisSpec axisParX{300, 0, 600, "#it{x} [cm]"};
const AxisSpec axisParY{200, -0.5, 0.5, "#it{y} [cm]"};
const AxisSpec axisParZ{200, -11., 11., "#it{z} [cm]"};
const AxisSpec axisParAlpha{36, -M_PI, M_PI, "#alpha [rad]"};

Check failure on line 219 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[external-pi] 

Use the PI constant (and its multiples and fractions) defined in o2::constants::math.
const AxisSpec axisParSigned1Pt{500, -8, 8, "#it{q}/#it{p}_{T}"};
const AxisSpec axisParSnp{11, -0.1, 0.1, "snp"};
const AxisSpec axisParTgl{200, -1., 1., "tgl"};
Expand Down Expand Up @@ -245,9 +245,12 @@
histos.add("Events/nContrib", "", kTH1D, {axisVertexNumContrib});
histos.add("Events/nContribVsFilteredMult", "", kTH2D, {axisVertexNumContrib, axisTrackMultiplicity});
histos.add("Events/nContribVsMult", "", kTH2D, {axisVertexNumContrib, axisTrackMultiplicity});
histos.add("Events/nContribVsAtLeastITSMult", "", kTH2D, {axisVertexNumContrib, axisTrackMultiplicity});
histos.add("Events/nContribWithTOFvsWithTRD", ";PV contrib. with TOF; PV contrib. with TRD;", kTH2D, {axisVertexNumContrib, axisVertexNumContrib});
histos.add("Events/nContribAllvsWithTRD", ";PV contrib. all; PV contrib. with TRD;", kTH2D, {axisVertexNumContrib, axisVertexNumContrib});
histos.add("Events/vertexChi2", ";#chi^{2}", kTH1D, {{100, 0, 100}});
histos.add("Events/vertexChi2OvernContrib", ";#chi^{2} / n contrib.", kTH1D, {{100, 0, 100}});
histos.add("Events/vertexChi2VsnContrib", ";#chi^{2};n contrib.", kTH2D, {{100, 0, 100}, axisVertexNumContrib});

histos.add("Events/covXX", ";Cov_{xx} [cm^{2}]", kTH1D, {axisVertexCov});
histos.add("Events/covXY", ";Cov_{xy} [cm^{2}]", kTH1D, {axisVertexCov});
Expand Down Expand Up @@ -735,19 +738,19 @@
LOG(info) << "================================";
LOG(info) << "=== soa::Filtered<TrackTableData> const& tracks, size=" << tracks.size();
int iTrack = 0;
for (auto& t : tracks) {

Check failure on line 741 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
LOG(info) << "[" << iTrack << "] .index()=" << t.index() << ", .globalIndex()=" << t.globalIndex();
iTrack++;
}
LOG(info) << "=== aod::FullTracks const& tracksUnfiltered, size=" << tracksUnfiltered.size();
int iTrackUnfiltered = 0;
for (auto& tuf : tracksUnfiltered) {

Check failure on line 747 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
LOG(info) << "[" << iTrackUnfiltered << "] .index()=" << tuf.index() << ", .globalIndex()=" << tuf.globalIndex();
iTrackUnfiltered++;
}
LOG(info) << "=== aod::AmbiguousTracks const& ambitracks, size=" << ambitracks.size();
int iTrackAmbi = 0;
for (auto& tamb : ambitracks) {

Check failure on line 753 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
LOG(info) << "[" << iTrackAmbi << "] .index()=" << tamb.index() << ", .globalIndex()=" << tamb.globalIndex() << ", .trackId()=" << tamb.trackId();
iTrackAmbi++;
}
Expand Down Expand Up @@ -1064,7 +1067,7 @@

/// check correct track-to-vertex matching exploiting MC info
std::vector<int> vec_coll_index_mismatched = {};
for (auto& track : tracks) {

Check failure on line 1070 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
histos.fill(HIST("Tracks/TestMCtrackToVtxMatch/ptAllTracks"), track.pt());
bool has_MCparticle = track.has_mcParticle();
if (track.collisionId() >= 0) {
Expand Down Expand Up @@ -1286,11 +1289,15 @@
}

int nFilteredTracks = 0;
int atLeastITSTracks = 0;
for (const auto& track : tracks) {
if (checkOnlyPVContributor && !track.isPVContributor()) {
continue;
}
histos.fill(HIST("Tracks/selection"), 1.f);
if (track.hasITS()) {
atLeastITSTracks++;
}
if (!isSelectedTrack<IS_MC>(track)) {
continue;
}
Expand Down Expand Up @@ -1437,7 +1444,10 @@
histos.fill(HIST("Events/nContrib"), collision.numContrib());
histos.fill(HIST("Events/nContribVsFilteredMult"), collision.numContrib(), nFilteredTracks);
histos.fill(HIST("Events/nContribVsMult"), collision.numContrib(), tracksUnfiltered.size());
histos.fill(HIST("Events/nContribVsAtLeastITSMult"), collision.numContrib(), atLeastITSTracks);
histos.fill(HIST("Events/vertexChi2"), collision.chi2());
histos.fill(HIST("Events/vertexChi2OvernContrib"), collision.chi2() / collision.numContrib());
histos.fill(HIST("Events/vertexChi2VsnContrib"), collision.chi2(), collision.numContrib());

histos.fill(HIST("Events/covXX"), collision.covXX());
histos.fill(HIST("Events/covXY"), collision.covXY());
Expand Down Expand Up @@ -1615,7 +1625,7 @@
auto pdgInfo = pdgDB->GetParticle(particle.pdgCode());
int sign = 0;
if (pdgInfo != nullptr) {
sign = pdgInfo->Charge() / abs(pdgInfo->Charge());

Check failure on line 1628 in DPG/Tasks/AOTTrack/qaEventTrack.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
}
// resolution plots
if (doExtraPIDqa && track.pidForTracking() != static_cast<unsigned int>(std::abs(PartIdentifier))) {
Expand Down
Loading