[PWGLF] NucleiTask - Add mothers for Deuteron #12928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannimalfattore
requested review from
alibuild,
fmazzasc,
maciacco,
mpuccio and
skundu692
as code owners
|
O2 linter results: ❌ 2 errors, |
github-actions
bot
changed the title
vkucera
reviewed
Sep 9, 2025
|
|
||
| Configurable<bool> enableTrackingEff{"enableTrackingEff", 0, "Flag to enable tracking efficiency hitos."}; | ||
| Configurable<std::string> ccdburl{"ccdb-url", "http://alice-ccdb.cern.ch", "url of the ccdb repository"}; | ||
| Configurable<std::string> ccdburl{"ccdb-url", "http://alice-ccdb.cern.ch", "url of the ccdb repository"}; // NOLINT |
Collaborator
There was a problem hiding this comment.
Why?
- This will not work.
- Silencing is not well justified here.
Contributor
Author
There was a problem hiding this comment.
@vkucera I have seen that ccdburl variable is usually written all lowercase in most of the analyses and I don't want to change it
Collaborator
There was a problem hiding this comment.
As you prefer, but majority by copy-pasting does not make things correct.
Regardless, your directive is silencing cpplint, not O2 linter.
vkucera
reviewed
Sep 9, 2025
vkucera
reviewed
Sep 9, 2025
Collaborator
maciacco
approved these changes
Sep 11, 2025
jmunozme
pushed a commit
to jmunozme/O2Physics
that referenced
this pull request
Oct 3, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.