-
Notifications
You must be signed in to change notification settings - Fork 613
[Common] Refactor ft0CorrectedTable by removing unused processes #12910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
O2 linter results: ❌ 8 errors, |
|
As discussed with @andreasmolander |
Pull request was converted to draft
|
On hold after discussing with @rbailhac |
|
Hi @njacazio, My comments:
Otherwise OK |
|
Ciao @andreasmolander many thanks, indeed, cleaner now. I would move on starting next week unless @rbailhac has something against (in any case the old version would be available via the previous O2Physics versions). |
|
Hi all, thanks for keeping us informed. "in any case the old version would be available via the previous O2Physics versions" is not really helping for us, because the format and information contained in our derived data is also changing. We need therefore latest O2Physics to produced derived data for MCs and at the same time this old bug fix for the old MCs. If you absolutely want to remove it, we will open our cuts artificially on old MCs to match with the expectations. |
Removed the processStandard and processWithBypassFT0timeInMC functions, along with related logging and histogram additions. Updated the function signature to process.
cb03957 to
4489dca
Compare
|
Error while checking build/O2Physics/o2 for e195c17 at 2025-09-23 22:15: Full log here. |
|
This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days. |
Added metadata check to prevent workflow usage with specific AO2D.
Added metadata initialization and validation for MC workflow.
|
Uses features introduced in #13343 to ensure correct usage |
Removed the processStandard and processWithBypassFT0timeInMC functions, along with related logging and histogram additions. Updated the function signature to process.