Skip to content

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Sep 8, 2025

Removed the processStandard and processWithBypassFT0timeInMC functions, along with related logging and histogram additions. Updated the function signature to process.

@github-actions github-actions bot added the common label Sep 8, 2025
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

O2 linter results: ❌ 8 errors, ⚠️ 10 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Refactor ft0CorrectedTable by removing unused processes [Common] Refactor ft0CorrectedTable by removing unused processes Sep 8, 2025
@njacazio njacazio marked this pull request as ready for review September 8, 2025 14:32
@njacazio njacazio enabled auto-merge (squash) September 8, 2025 14:32
@njacazio
Copy link
Collaborator Author

njacazio commented Sep 8, 2025

As discussed with @andreasmolander

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 76e1b58 at 2025-09-11 21:07:

No log files found

Full log here.

@njacazio njacazio marked this pull request as draft September 16, 2025 08:04
auto-merge was automatically disabled September 16, 2025 08:04

Pull request was converted to draft

@njacazio
Copy link
Collaborator Author

On hold after discussing with @rbailhac

@andreasmolander
Copy link
Contributor

Hi @njacazio,

My comments:

  • Remove
    Configurable<float> resoFT0A{"resoFT0A", 20.f, "FT0A resolution in ps for the MC override"};
    Configurable<float> resoFT0C{"resoFT0C", 20.f, "FT0C resolution in ps for the MC override"};
    ?
  • Remove
    Configurable<int> cfgCollisionSystem{"collisionSystem", -2, "Collision system: -2 (use cfg values), -1 (autoset), 0 (pp), 1 (PbPb), 2 (XeXe), 3 (pPb)"};
    Configurable<std::string> cfgUrl{"ccdb-url", "http://alice-ccdb.cern.ch", "url of the ccdb repository"};
    Configurable<std::string> cfgPathGrpLhcIf{"ccdb-path-grplhcif", "GLO/Config/GRPLHCIF", "Path on the CCDB for the GRPLHCIF object"};
    Configurable<int64_t> cfgTimestamp{"ccdb-timestamp", -1, "timestamp of the object"};
    Service<o2::ccdb::BasicCCDBManager> ccdb;
    ?
  • Remove
    ccdb->setURL(cfgUrl);
    ccdb->setTimestamp(cfgTimestamp);
    ccdb->setCaching(true);
    ccdb->setLocalObjectValidityChecking();
    // Not later than now objects
    ccdb->setCreatedNotAfter(std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::system_clock::now().time_since_epoch()).count());
    ?

Otherwise OK

@njacazio
Copy link
Collaborator Author

Ciao @andreasmolander many thanks, indeed, cleaner now. I would move on starting next week unless @rbailhac has something against (in any case the old version would be available via the previous O2Physics versions).

@njacazio njacazio marked this pull request as ready for review September 22, 2025 09:41
@njacazio njacazio enabled auto-merge (squash) September 22, 2025 09:41
@rbailhac
Copy link
Collaborator

Hi all, thanks for keeping us informed. "in any case the old version would be available via the previous O2Physics versions" is not really helping for us, because the format and information contained in our derived data is also changing. We need therefore latest O2Physics to produced derived data for MCs and at the same time this old bug fix for the old MCs. If you absolutely want to remove it, we will open our cuts artificially on old MCs to match with the expectations.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for cb03957 at 2025-09-23 15:21:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

njacazio and others added 2 commits September 23, 2025 17:42
Removed the processStandard and processWithBypassFT0timeInMC functions, along with related logging and histogram additions. Updated the function signature to process.
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for e195c17 at 2025-09-23 22:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12910-slc9_x86-64/0/Common/TableProducer/ft0CorrectedTableMcOverride.cxx:79:9: error: 'doprocessWithBypassFT0timeInMC' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@github-actions
Copy link

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions bot added the stale label Oct 25, 2025
@github-actions github-actions bot closed this Oct 30, 2025
auto-merge was automatically disabled October 30, 2025 01:56

Pull request was closed

@njacazio njacazio reopened this Nov 2, 2025
Added metadata check to prevent workflow usage with specific AO2D.
Added metadata initialization and validation for MC workflow.
@njacazio
Copy link
Collaborator Author

njacazio commented Nov 2, 2025

Uses features introduced in #13343 to ensure correct usage

@github-actions github-actions bot removed the stale label Nov 3, 2025
@alibuild
Copy link
Collaborator

alibuild commented Nov 24, 2025

Error while checking build/O2Physics/o2 for 7388668 at 2025-12-21 00:05:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants