[Common] Sanitize power-law mapping in corner cases #12826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 38 errors, |
…p#12823) Co-authored-by: Lucamicheletti93 <luca.mike93@gmail.com>
ddobrigk
requested review from
iarsene,
lucamicheletti93 and
mcoquet642
as code owners
auto-merge was automatically disabled
September 2, 2025 13:07
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a corner case in the power-law mapping of data to MC used in the centrality framework that was leading to NaNs when specific sets of parameters were used.
Interestingly, even if the MC calibration mapping procedure has been power-law-based for many years, this corner case in which parameters led to NaNs in the intermediate evaluation has only appeared in light ion monte carlo. This adjustment will sanitize all instances of this effect also in the future, as the mapping function is adjusted in the evaluation code (no change needed in ccdb).
Tagging @abmodak @romainschotter who also helped me with the debugging. Thanks!