Skip to content

[PWGLF] add new table for Hypertiton collision ID #12824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maciacco merged 13 commits into from
Sep 4, 2025
Merged

[PWGLF] add new table for Hypertiton collision ID #12824

maciacco merged 13 commits into from
Sep 4, 2025

Conversation

@blacwovie
Copy link
Contributor

@blacwovie blacwovie commented Sep 2, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 2, 2025 •
edited
Loading

O2 linter results: ❌ 67 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title add new table for Hypertiton collision ID [PWGLF] add new table for Hypertiton collision ID Sep 2, 2025
@alibuild alibuild mentioned this pull request Sep 2, 2025
Merged
@alibuild alibuild mentioned this pull request Sep 2, 2025
Merged
@blacwovie blacwovie marked this pull request as ready for review September 3, 2025 07:18
@maciacco maciacco enabled auto-merge (squash) September 3, 2025 08:25
maciacco
maciacco previously approved these changes Sep 3, 2025
View reviewed changes
@maciacco maciacco disabled auto-merge September 3, 2025 08:26
@alibuild
Copy link
Collaborator

alibuild commented Sep 3, 2025

Error while checking build/O2Physics/o2 for f9aa132 at 2025-09-03 13:24:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12824-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:413:51: error: expected '(' before 'heTrack'
/sw/SOURCES/O2Physics/12824-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:413:112: error: expected ')' before ';' token
/sw/SOURCES/O2Physics/12824-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:416:50: error: expected '(' before 'piTrack'
/sw/SOURCES/O2Physics/12824-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx:416:111: error: expected ')' before ';' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Sep 4, 2025
Merged
maciacco
maciacco previously approved these changes Sep 4, 2025
View reviewed changes
PWGLF/TableProducer/Nuspex/hyperRecoTask.cxx Outdated
hypCand.nTPCClustersHe3 = heTrack.tpcNClsFound();
hypCand.tpcSignalHe3 = heTrack.tpcSignal();
hypCand.nTPCpidClusHe3 = (int16_t)heTrack.tpcNClsFindable() - heTrack.tpcNClsFindableMinusPID();
hypCand.nTPCpidClusHe3 = static_cast<int16_t> heTrack.tpcNClsFindable() - heTrack.tpcNClsFindableMinusPID();
Copy link
Collaborator

@maciacco maciacco Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the missing parantheses here in the cast statement

Copy link
Contributor Author

@blacwovie blacwovie Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I'm bit confused. In line 413, I would like to ask whether the cast to int16_t here is applied only to heTrack.tpcNClsFindable(), or to the entire expression heTrack.tpcNClsFindable() - heTrack.tpcNClsFindableMinusPID().

Copy link
Contributor Author

@blacwovie blacwovie Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's the former then I made a mistake to cast entire expression to int16_t

Copy link
Collaborator

@maciacco maciacco Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled the auto-merge so that you can make the change

Copy link
Contributor Author

@blacwovie blacwovie Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Thank you Mario:)

@maciacco maciacco enabled auto-merge (squash) September 4, 2025 08:36
@maciacco maciacco disabled auto-merge September 4, 2025 09:00
@maciacco maciacco enabled auto-merge (squash) September 4, 2025 10:27
@maciacco maciacco merged commit fadd22f into AliceO2Group:master Sep 4, 2025
13 of 14 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@blacwovie @alibuild @jinhyunni
[PWGLF] add new table for Hypertiton collision ID (AliceO2Group#12824)
16711da 
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@blacwovie @alibuild @ThePhDane
[PWGLF] add new table for Hypertiton collision ID (AliceO2Group#12824)
59c7301 
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@blacwovie @alibuild @jloemker
[PWGLF] add new table for Hypertiton collision ID (AliceO2Group#12824)
77d14c3 
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@blacwovie @alibuild
[PWGLF] add new table for Hypertiton collision ID (AliceO2Group#12824)
8f7a00b 
Co-authored-by: blacw <blacw@blacwdeMacBook-Air.local>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciacco maciacco maciacco approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blacwovie @alibuild @maciacco