[Common] Further adjustments and cleanup to common services #12809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddobrigk
requested review from
a team,
alibuild,
iarsene,
jgrosseo,
ktf and
victor-gonzalez
as code owners
|
O2 linter results: ❌ 143 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 974fd4b at 2025-08-31 18:52: Full log here. |
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
…roup#12809) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
…roup#12809) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
…roup#12809) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
…roup#12809) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustments in naming of internal components of the new services (transparent to users)
For future developments: @romainschotter this explicitly adds a Run 2 and Run 3 version of the TPC PID to avoid the (incorrect) circular dependency failure when enabling better TPC PID pre-selections in the strangeness builder module (which I think should really be done soon). This isn't a pretty way to do it, but it has to be done this way until we finally get the fix for metadata reading at
defineDataProcessingthat also works on Hyperloop (I will ping experts on this again...)