[PWGEM/Dilepton,Trigger] update trigger analysis in LMEE #12798
Conversation
dsekihat
requested review from
alibuild,
feisenhu,
hscheid,
ivorobye,
lietava,
m-c-danisch,
mhemmer-cern,
mikesas,
mpuccio,
novitzky and
rbailhac
as code owners
|
O2 linter results: ❌ 2108 errors, |
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#12798
|
Dear @mpuccio , I added another counter and its getter for normalization study. Can you have a loot at it? |
EventFiltering/Zorro.cxx
Outdated
| int binY = ToiHisto->GetYaxis()->FindBin(Form("%s AnalysedTriggers", mTOIs[i].data())); | ||
| ToiHisto->SetBinContent(binX, binY, mAnalysedTriggers->GetBinContent(mAnalysedTriggers->GetXaxis()->FindBin(mTOIs[i].data()))); | ||
| } | ||
| mATcounts[i] += (mAnalysedTriggers->GetBinContent(mAnalysedTriggers->GetXaxis()->FindBin(mTOIs[i].data())) > mATcounts[i]); |
There was a problem hiding this comment.
I am not sure I follow the logic here, could you explain what you are looking for?
There was a problem hiding this comment.
Hello @mpuccio , Thank you for your question. This is equivalent to AnalysedTrigger at line 268. The trigger counters of both AnalysedTrigger and AnalyzedTriggerOfInterest are necessary to see double counting.
There was a problem hiding this comment.
I understand that you want to have the output for the analysed triggers, what I don't understand is why you want to have a counter that is incremented by 1 only if the content of the histogram is larger than the counter itself
There was a problem hiding this comment.
Ciao @mpuccio , Thank you for your comments in person and here. You are right. I moved into fetch(). Another improvement is that the counter is independent from mAnalysedTriggers. The purpose is trigger counter in bc by bc.
3 participants
PWGEM/Dilepton, Trigger: update trigger analysis in LMEE