[PWGHF] Task for D+ and Ds correlations in small systems #12776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 0 errors, |
[PWGHF] Please consider the following formatting changes to AliceO2Group#12776
|
|
||
| using CollsWithCentMult = soa::Join<aod::Collisions, aod::EvSels, aod::FT0Mults, aod::FV0Mults, aod::CentFT0Ms, aod::CentFT0As, aod::CentFT0Cs, aod::CentFV0As>; | ||
| using CandDsDataWMl = soa::Filtered<soa::Join<aod::HfCand3Prong, aod::HfSelDsToKKPi, aod::HfMlDsToKKPi>>; | ||
| using CandDsData = soa::Filtered<soa::Join<aod::HfCand3Prong, aod::HfSelDsToKKPi>>; |
Collaborator
There was a problem hiding this comment.
Personally I would remove the rectangualr-selection-based process functions and the relative filtered table. We will anyway use BDTs for these studies (from pp or OO when the MC will be out)
| }; // end init | ||
|
|
||
| /// Check event selections for collision and fill the collision table | ||
| /// \param collision is the collision with the Q vector information and event plane |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// \param collision is the collision with the Q vector information and event plane | |
| /// \param collision is the collision |
|
|
||
| /// Fill charm hadron tables | ||
| /// \param candidates are the selected charm hadron candidates | ||
| template <DecayChannel channel, bool applyMl, typename TCand> |
Collaborator
There was a problem hiding this comment.
if you remove the non-ml cases, the applyMl bool is not necessary anymore
Collaborator
|
Hi @Marcellocosti! Thanks a lot for the development. I had a look and it seems ok to me, I just added few of comments you might want to consider. |
Marcellocosti
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
vkucera and
zhangbiao-phy
as code owners
Contributor
Author
|
Hi @stefanopolitano, I tried to implement your suggestions, please let me know if I missed anything! |
Collaborator
|
Hi @Marcellocosti ! Good for me, thanks! |
stefanopolitano
approved these changes
Aug 28, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
…p#12776) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
…p#12776) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
…p#12776) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
…p#12776) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stefanopolitano, @scattaru! Here a first version of the task that we could use to fill the tables for Ds and D+ to study the correlations in small systems. Please let me know your feedback!