-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGCF] FemtoDream: added event sphericity calculation #12677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code for shpericity calculation. Sphericity matrix is taken from: EPJC72:2124
Deleted cascade producer for compatibility reasons with sphericity calculation.
Sphericity calculation: added MinSphericity and SphericityPtmin configurables as event cuts
Sphericity calculation: added MinSphericity and SphericityPtmin configurables as event cuts
…des.cxx Removed file, due to incompatibility with sphericity calculation
Added sphericity event cuts
|
O2 linter results: ❌ 365 errors, |
Please consider the following formatting changes to AliceO2Group#12677
lauraser
reviewed
Aug 21, 2025
Collaborator
lauraser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments on the code, I will approve the PR once I test it locally
Slight change of the sphericity matrix element definition
Please consider the following formatting changes to AliceO2Group#12677
Bugfix: changed hardcoded value for minimal pT used for calculating the sphericity to variable mSphericityPtmin
lauraser
approved these changes
Aug 22, 2025
gitchrishub-oss
pushed a commit
to gitchrishub-oss/O2Physics
that referenced
this pull request
Aug 23, 2025
…12677) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
fcatalan92
pushed a commit
to fcatalan92/O2Physics
that referenced
this pull request
Aug 25, 2025
…12677) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
…12677) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
…12677) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
…12677) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
…12677) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature: event sphericity calculation in FemtoDream framework