Skip to content

Conversation

@mfaggin
Copy link
Collaborator

@mfaggin mfaggin commented Aug 20, 2025

Possible solution to avoid any rewrite of the same files if the --pipeline option is used in Hyperloop for the device instantiating the TrackTuner

@ddobrigk @fcatalan92 @arossi81 @phymanshu

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

O2 linter results: ❌ 21 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Customize tmpDir for TrackTuner download accoding to track-propagation devices. [Common] Customize tmpDir for TrackTuner download accoding to track-propagation devices. Aug 20, 2025
for (const DeviceSpec& device : workflows.devices) {
if (device.name.compare("track-propagation") == 0) {
// init HF event selection helper
LOG(info) << " FOUND!";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfaggin ! I would remove this log with "FOUND" in favor of something after the loop reporting the count of devices, i.e. LOGF(info, "Number of track propagation tasks detected: %i", counter); or so. Could you please adjust?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ddobrigk , you are totally right. Done in my last commit

@ddobrigk
Copy link
Collaborator

One more thing: as you might have seen, the track propagation task is now deprecated and replaced by the propagationService, which has a series of autodetect improvements (including autodetection of needing or not needing the CovMat when propagating). It would be crucial, in fact, to have this solution also implemented in the file for the track propagation under Common/Tools, since the propagation service is an ideal task for pipelining. Could you please also make the necessary changes in the init function there? Thank you!

@mfaggin mfaggin changed the title [Common] Customize tmpDir for TrackTuner download accoding to track-propagation devices. [Common] Protect against multiple downloads from TrackTuner Aug 20, 2025
@mfaggin
Copy link
Collaborator Author

mfaggin commented Aug 20, 2025

Hi @ddobrigk, actually the solution that I was proposing before was not working, since I was always getting N as number of devices, where N were the instances of track-propagation devices instantiated.

I changed the kogic directly in the TrackTuner utility, where before retrieving the file from CCDB it now checks if the desired file has been already downloaded. this should automatically fix the things also for the propagationService.

@mfaggin mfaggin marked this pull request as ready for review August 20, 2025 17:17
@mfaggin mfaggin requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners August 20, 2025 17:17
@mfaggin mfaggin marked this pull request as draft August 21, 2025 08:17
@mfaggin
Copy link
Collaborator Author

mfaggin commented Aug 21, 2025

In this separate branch I put the implementation I had in mind to make the file being downloaded in different folders by the different TrackTuner folders: https://github.com/AliceO2Group/O2Physics/compare/master...mfaggin:O2Physics:fixCcdbQueryTrackTuner_gRandom?expand=1

The idea is to let the two instances downloade in the folders ./<number>. In this implementation <number> is just a random one extracted with gRandom. It would be better of course to use the device id, as I asked in Mattermost to @ktf , let's see if he has some suggestions on it.

@mfaggin
Copy link
Collaborator Author

mfaggin commented Aug 26, 2025

Hi, I have just opened another draft PR here #12748 where I propose the usage of getfromTimeStamp instead of retrieveBlob, which should do what we want. This would imply the reload of all calibration files, but they are not too many (less than 10)

@github-actions
Copy link

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions bot added the stale label Sep 26, 2025
@github-actions github-actions bot closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants