-
Notifications
You must be signed in to change notification settings - Fork 613
[Common] Protect against multiple downloads from TrackTuner #12650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 21 errors, |
| for (const DeviceSpec& device : workflows.devices) { | ||
| if (device.name.compare("track-propagation") == 0) { | ||
| // init HF event selection helper | ||
| LOG(info) << " FOUND!"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mfaggin ! I would remove this log with "FOUND" in favor of something after the loop reporting the count of devices, i.e. LOGF(info, "Number of track propagation tasks detected: %i", counter); or so. Could you please adjust?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ddobrigk , you are totally right. Done in my last commit
|
One more thing: as you might have seen, the track propagation task is now deprecated and replaced by the |
|
Hi @ddobrigk, actually the solution that I was proposing before was not working, since I was always getting I changed the kogic directly in the |
|
In this separate branch I put the implementation I had in mind to make the file being downloaded in different folders by the different The idea is to let the two instances downloade in the folders |
|
Hi, I have just opened another draft PR here #12748 where I propose the usage of |
|
This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days. |
Possible solution to avoid any rewrite of the same files if the
--pipelineoption is used in Hyperloop for the device instantiating theTrackTuner@ddobrigk @fcatalan92 @arossi81 @phymanshu