[PWGJE] Adding Ds and Xic to jet framework #12640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzardosh
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa and
mhemmer-cern
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 505 errors, |
vkucera
requested changes
Aug 19, 2025
Comment on lines
+65
to
+73
| namespace bkgds | ||
| { | ||
| DECLARE_SOA_INDEX_COLUMN_FULL(Candidate, candidate, int, HfDsBases, "_0"); | ||
| } // namespace bkgds | ||
|
|
||
| namespace bkgdsmc | ||
| { | ||
| DECLARE_SOA_INDEX_COLUMN_FULL(Candidate, candidate, int, HfDsPBases, "_0"); | ||
| } // namespace bkgdsmc |
Collaborator
There was a problem hiding this comment.
Why do you need two columns and not one?
Collaborator
Author
There was a problem hiding this comment.
Because they are pointing to different tables
Collaborator
There was a problem hiding this comment.
Indeed, sorry, I overlooked the P.
Comment on lines
+97
to
+98
| o2physics_add_dpl_workflow(jet-finder-ds-mcd-charged | ||
| SOURCES jetFinderDsMCDCharged.cxx |
Collaborator
There was a problem hiding this comment.
The capitalisation should be fixed at some point.
| PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::PWGJECore O2Physics::AnalysisCore O2::FrameworkPhysicsSupport | ||
| COMPONENT_NAME Analysis) | ||
|
|
||
| o2physics_add_dpl_workflow(jet-finder-xictoxipipi-data-charged |
Collaborator
There was a problem hiding this comment.
Suggested change
| o2physics_add_dpl_workflow(jet-finder-xictoxipipi-data-charged | |
| o2physics_add_dpl_workflow(jet-finder-xic-to-xi-pi-pi-data-charged |
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
|
|
||
| // jet finder D+ mcp charged task |
| PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::PWGJECore O2Physics::AnalysisCore O2::FrameworkPhysicsSupport | ||
| COMPONENT_NAME Analysis) | ||
|
|
||
| o2physics_add_dpl_workflow(jet-matching-mc-xictoxipipi-ch |
Collaborator
There was a problem hiding this comment.
Fix the hyphenation everywhere.
| // | ||
| /// \author Nima Zardoshti <nima.zardoshti@cern.ch> | ||
|
|
||
| #include "PWGJE/TableProducer/Matching/Substructure/jetSubstructureMatching.cxx" |
Collaborator
There was a problem hiding this comment.
Use header files for reusable code and source files for compilation units.
Never ever include source files.
|
|
||
| #include <vector> | ||
|
|
||
| using DsChargedJetSubstructureMatchingMC = JetSubstructureMatching<soa::Join<aod::DsChargedMCDetectorLevelJets, aod::DsChargedMCDetectorLevelJetConstituents, aod::DsChargedMCDetectorLevelJetsMatchedToDsChargedMCParticleLevelJets>, |
Collaborator
There was a problem hiding this comment.
The task name does not match the file name.
|
|
||
| tasks.emplace_back( | ||
| adaptAnalysisTask<DsChargedMCJetsEventWeight>(cfgc, | ||
| SetDefaultProcesses{}, TaskName{"jet-ds-eventweight-mcp-charged"})); |
Collaborator
There was a problem hiding this comment.
Suggested change
| SetDefaultProcesses{}, TaskName{"jet-ds-eventweight-mcp-charged"})); | |
| SetDefaultProcesses{}, TaskName{"jet-ds-event-weight-mcp-charged"})); |
eventweight is not a word.
vkucera
approved these changes
Aug 20, 2025
gitchrishub-oss
pushed a commit
to gitchrishub-oss/O2Physics
that referenced
this pull request
Aug 23, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.