[PWGJE] V0 Jet Finder #12636
Merged
[PWGJE] V0 Jet Finder #12636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed THnSparse to THnD from THnC When used in an analysis train the THnC overflows, resulting in negative entries (see attached figure). This is likely due ot the fact that the bin content is stored in a char, rather than a float/double. Changing this should fix the issue. This histogram is used only for V0 jet analyses, so this change affects no other jet work.
GijsvWeelden
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 21 errors, |
nzardosh
approved these changes
Aug 20, 2025
gitchrishub-oss
pushed a commit
to gitchrishub-oss/O2Physics
that referenced
this pull request
Aug 23, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This histogram is used only for V0 jet analyses, so this change affects no other jet work.
When used in an analysis train the THnC overflows, resulting in negative entries (see attached figure). This can be seen in e.g. trains 426828 and 474334.
The issue is likely due to the fact that the bin content is stored in a char, rather than a float/double. Changing this should fix the issue.