Skip to content

[PWGLF] Add shift correctionfor event plane calibration #12630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romainschotter merged 5 commits into from
Aug 20, 2025
Merged

[PWGLF] Add shift correctionfor event plane calibration #12630

romainschotter merged 5 commits into from
Aug 20, 2025

Conversation

@ChiaraDeMartin95
Copy link
Collaborator

@ChiaraDeMartin95 ChiaraDeMartin95 commented Aug 19, 2025

No description provided.

@ChiaraDeMartin95 ChiaraDeMartin95 marked this pull request as ready for review August 19, 2025 09:17
@github-actions github-actions bot added the pwglf label Aug 19, 2025
@github-actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

O2 linter results: ❌ 127 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add shift correctionfor event plane calibration [PWGLF] Add shift correctionfor event plane calibration Aug 19, 2025
@alibuild alibuild mentioned this pull request Aug 19, 2025
Merged
@ChiaraDeMartin95
Merge pull request #33 from alibuild/alibot-cleanup-12630
506729e 
Please consider the following formatting changes to AliceO2Group#12630
romainschotter
romainschotter previously approved these changes Aug 19, 2025
View reviewed changes
@romainschotter romainschotter enabled auto-merge (squash) August 19, 2025 10:16
@alibuild
Copy link
Collaborator

alibuild commented Aug 19, 2025

Error while checking build/O2Physics/o2 for 506729e at 2025-08-19 12:53:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12630-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/cascadeflow.cxx:516:3: error: no return statement in function returning non-void [-Werror=return-type]
/sw/SOURCES/O2Physics/12630-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/cascadeflow.cxx:516:3: error: no return statement in function returning non-void [-Werror=return-type]
/sw/SOURCES/O2Physics/12630-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/cascadeflow.cxx:516:3: error: no return statement in function returning non-void [-Werror=return-type]
ninja: build stopped: subcommand failed.

Full log here.

@romainschotter romainschotter merged commit f2644b2 into AliceO2Group:master Aug 20, 2025
10 of 12 checks passed
gitchrishub-oss pushed a commit to gitchrishub-oss/O2Physics that referenced this pull request Aug 23, 2025
@ChiaraDeMartin95 @alibuild
[PWGLF] Add shift correctionfor event plane calibration (AliceO2Group…
546b16c 
…#12630)

Co-authored-by: Chiara De Martin <chdemart@alicecerno2.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@ChiaraDeMartin95 @alibuild @jinhyunni
[PWGLF] Add shift correctionfor event plane calibration (AliceO2Group…
56394d1 
…#12630)

Co-authored-by: Chiara De Martin <chdemart@alicecerno2.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@ChiaraDeMartin95 @alibuild @ThePhDane
[PWGLF] Add shift correctionfor event plane calibration (AliceO2Group…
d1df7bc 
…#12630)

Co-authored-by: Chiara De Martin <chdemart@alicecerno2.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@ChiaraDeMartin95 @alibuild @jloemker
[PWGLF] Add shift correctionfor event plane calibration (AliceO2Group…
6e01e85 
…#12630)

Co-authored-by: Chiara De Martin <chdemart@alicecerno2.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@ChiaraDeMartin95 @alibuild
[PWGLF] Add shift correctionfor event plane calibration (AliceO2Group…
5b9e3a6 
…#12630)

Co-authored-by: Chiara De Martin <chdemart@alicecerno2.cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainschotter romainschotter romainschotter approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChiaraDeMartin95 @alibuild @romainschotter