-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGCF] Adding V0-V0 pair task #12614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gmantzar
commented
Aug 18, 2025
- Included the V0V0 pair task
- updated the ClosePairRejection task to support V0-V0 pairs
|
O2 linter results: ❌ 222 errors, |
|
Error while checking build/O2Physics/o2 for 711f049 at 2025-08-18 20:37: Full log here. |
|
Dear @gmantzar and @victor-gonzalez, this PR deleted two tasks in the CMakeLists.txt, which are actively used and are developed by other people. One of them is now being re-included by @wrzesaCERN. The other one is from @AntonRiedel for efficiency. This is completely unacceptable and should never have happened as these tasks are already used in hyperloop; all new tags don't have them anymore. Moreover, it is likely that after re-implementation, multiple configurations in Hyperloop will be lost. Please ensure that such incidents do not happen again in the future. Especially be careful if you do PRs on behalf of your students. |
@lauraser I accept my part on this and completely agree with you, but you and Anton were also asked about reviewing it. When I saw your silence and Georgios query I didn't doubt |
|
@victor-gonzalez yes, I totally agree with you! I, unfortunately, had a problem with my GitHub emails that I did not notice before. I have fixed the issue today and I should get properly notified about all PRs now. |
Co-authored-by: Bianca-Maria Popa <ge84qed@nidoking.ktas.ph.tum.de>
Co-authored-by: Bianca-Maria Popa <ge84qed@nidoking.ktas.ph.tum.de>
Co-authored-by: Bianca-Maria Popa <ge84qed@nidoking.ktas.ph.tum.de>