Skip to content

Conversation

@gmantzar
Copy link
Contributor

  • Included the V0V0 pair task
  • updated the ClosePairRejection task to support V0-V0 pairs

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

O2 linter results: ❌ 222 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title [PWGCF]: Adding V0-V0 pair task [PWGCF] Adding V0-V0 pair task Aug 18, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for ba1fed4 at 2025-08-18 13:27:

No log files found

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for cd974ea at 2025-08-18 17:30:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddWorkflow.cmake:35 (message):

Full log here.

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) August 18, 2025 17:06
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 711f049 at 2025-08-18 20:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12614-slc9_x86-64/0/PWGCF/FemtoDream/Tasks/femtoDreamPairTaskV0V0.cxx:222:26: error: unused parameter 'context' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez victor-gonzalez merged commit 70aa8c2 into AliceO2Group:master Aug 19, 2025
12 of 13 checks passed
@gmantzar gmantzar deleted the lambdalambda branch August 19, 2025 06:33
@lauraser
Copy link
Collaborator

lauraser commented Sep 9, 2025

Dear @gmantzar and @victor-gonzalez,

this PR deleted two tasks in the CMakeLists.txt, which are actively used and are developed by other people. One of them is now being re-included by @wrzesaCERN. The other one is from @AntonRiedel for efficiency. This is completely unacceptable and should never have happened as these tasks are already used in hyperloop; all new tags don't have them anymore. Moreover, it is likely that after re-implementation, multiple configurations in Hyperloop will be lost.

Please ensure that such incidents do not happen again in the future. Especially be careful if you do PRs on behalf of your students.

@victor-gonzalez
Copy link
Collaborator

Dear @gmantzar and @victor-gonzalez,

this PR deleted two tasks in the CMakeLists.txt, which are actively used and are developed by other people. One of them is now being re-included by @wrzesaCERN. The other one is from @AntonRiedel for efficiency. This is completely unacceptable and should never have happened as these tasks are already used in hyperloop; all new tags don't have them anymore. Moreover, it is likely that after re-implementation, multiple configurations in Hyperloop will be lost.

Please ensure that such incidents do not happen again in the future, as they are completely unacceptable. Especially be careful if you do PRs on behalf of your students.

@lauraser I accept my part on this and completely agree with you, but you and Anton were also asked about reviewing it. When I saw your silence and Georgios query I didn't doubt

@lauraser
Copy link
Collaborator

lauraser commented Sep 9, 2025

@victor-gonzalez yes, I totally agree with you! I, unfortunately, had a problem with my GitHub emails that I did not notice before. I have fixed the issue today and I should get properly notified about all PRs now.

ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
Co-authored-by: Bianca-Maria Popa <ge84qed@nidoking.ktas.ph.tum.de>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Co-authored-by: Bianca-Maria Popa <ge84qed@nidoking.ktas.ph.tum.de>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Co-authored-by: Bianca-Maria Popa <ge84qed@nidoking.ktas.ph.tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants