Skip to content

[PWGCF] jFlucEfficiencyTask - Modify structure and add systematic study histograms #12610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BongHwi merged 4 commits into from
Aug 19, 2025
Merged

[PWGCF] jFlucEfficiencyTask - Modify structure and add systematic study histograms #12610

BongHwi merged 4 commits into from
Aug 19, 2025

Conversation

@BongHwi
Copy link
Collaborator

@BongHwi BongHwi commented Aug 18, 2025

  • Add PID process for study
  • Add TPC sector dependence check
  • Add pT uncertainty histogram

@github-actions github-actions bot added the pwgcf label Aug 18, 2025
@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Aug 18, 2025
Merged
@BongHwi
Merge pull request #34 from alibuild/alibot-cleanup-12610
1380a8d 
Please consider the following formatting changes to AliceO2Group#12610
@alibuild
Copy link
Collaborator

alibuild commented Aug 18, 2025 •
edited
Loading

Error while checking build/O2Physics/o2 for 1380a8d at 2025-08-18 09:34:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:192:74: error: unknown conversion type character ')' in format [-Werror=format=]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:198:76: error: unknown conversion type character ')' in format [-Werror=format=]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:557:12: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:653:12: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:756:12: error: unused variable 'charge' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:406:75: error: unused parameter 'isMC' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:406:75: error: unused parameter 'isMC' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:406:75: error: unused parameter 'isMC' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12610-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:406:75: error: unused parameter 'isMC' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@BongHwi BongHwi enabled auto-merge (squash) August 19, 2025 06:49
@BongHwi
Copy link
Collaborator Author

BongHwi commented Aug 19, 2025

@victor-gonzalez Could you approve this PR?

@BongHwi BongHwi merged commit 9295aa4 into AliceO2Group:master Aug 19, 2025
12 checks passed
@BongHwi BongHwi deleted the JCorEffiMod branch August 20, 2025 05:25
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@BongHwi @alibuild @jinhyunni
[PWGCF] jFlucEfficiencyTask - Modify structure and add systematic stu…
4a6f9ba 
…dy histograms (AliceO2Group#12610)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@BongHwi @alibuild @ThePhDane
[PWGCF] jFlucEfficiencyTask - Modify structure and add systematic stu…
f5d71d1 
…dy histograms (AliceO2Group#12610)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@BongHwi @alibuild @jloemker
[PWGCF] jFlucEfficiencyTask - Modify structure and add systematic stu…
2b54543 
…dy histograms (AliceO2Group#12610)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@BongHwi @alibuild
[PWGCF] jFlucEfficiencyTask - Modify structure and add systematic stu…
e07a19c 
…dy histograms (AliceO2Group#12610)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BongHwi @alibuild @victor-gonzalez