Skip to content

Conversation

@abmodak
Copy link
Collaborator

@abmodak abmodak commented Aug 15, 2025

No description provided.

@github-actions
Copy link

O2 linter results: ❌ 4 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Modify in FV0 eta calculation and add kIsGoodZvtxFT0vsPV event selection [PWGCF] Modify in FV0 eta calculation and add kIsGoodZvtxFT0vsPV event selection Aug 15, 2025
@abmodak abmodak enabled auto-merge (squash) August 16, 2025 01:53
Filter fMftTrackDca = (nabs(aod::fwdtrack::bestDCAXY) < cfigMftDcaxy);

double getPhiFT0(int chno, int i)
double getPhiFT0(UInt_t chno, int i)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, follow linter recommendations and use uint

}

double getPhiFV0(int chno)
double getPhiFV0(UInt_t chno)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

}
histos.fill(HIST("QA/EventHist"), 3);
if (std::abs(col.posZ()) >= cfgVtxCut) {
if (isApplyGoodZvtxFT0vsPV && !col.selection_bit(o2::aod::evsel::kIsGoodZvtxFT0vsPV)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware of the usage of kIsGoodZvtxFT0vsPV recommendations at AOT and light ions meetings

Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, have a look at my comments in case you want to consider them for future iterations

@abmodak abmodak merged commit 4da2ac7 into AliceO2Group:master Aug 16, 2025
15 of 16 checks passed
@abmodak abmodak deleted the update-longrange branch August 21, 2025 01:59
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants