Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Aug 14, 2025

  • Fix multiplicity type (uint16_t):
    • PWGHF/Core/CentralityEstimation.h:getCentralityGenColl
    • PWGHF/D2H/TableProducer/dataCreatorCharmHadPiReduced.cxx
    • PWGHF/Utils/utilsEvSelHf.h:getOccupancyGenColl
  • Fix collision rejection mask type (uint32_t):
    • PWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx
  • Fix occupancy type (float):
    • PWGHF/Utils/utilsEvSelHf.h:getOccupancyGenColl
    • PWGHF/Tasks/taskMcValidation.cxx
  • Fix wrong passing by reference:
    • PWGHF/Utils/utilsAnalysis.h:isCandidateInMassRange
    • PWGHF/Utils/utilsEvSelHf.h:fillHistograms
    • PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx:fillThn
    • PWGHF/D2H/TableProducer/dataCreatorJpsiHadReduced.cxx:fillMcRecoInfo
    • PWGHF/D2H/TableProducer/dataCreatorCharmResoReduced.cxx:fillMcRecoInfoDTrack
    • PWGHF/D2H/Tasks/taskFlowCharmHadrons.cxx:getQvecDtracks
  • Fix missing member initialisation:
    • PWGHF/Utils/utilsEvSelHf.h:HfEventSelectionMc
  • Add passing by reference:
    • PWGHF/Utils/utilsEvSelHf.h:setEventRejectionLabels
  • Define HfDecayChannel type (int8_t).
  • Define HfCollisionRejectionMask type (uint32_t).
  • Remove unnecessary template:
    • PWGHF/Utils/utilsDerivedData.h:reserveTables...
  • Use meaningful template typenames.
  • Use const as much as possible.
  • Use auto for assigning function return values.
  • Use fully qualified names:
    • o2::hf_occupancy::getOccupancyColl
    • o2::hf_occupancy::getOccupancyGenColl
  • Refer to enum definitions in fatal errors.
    • CentralityEstimator
    • OccupancyEstimator

@github-actions
Copy link

github-actions bot commented Aug 14, 2025

O2 linter results: ❌ 63 errors, ⚠️ 0 warnings, 🔕 53 disabled

@github-actions github-actions bot changed the title Utils: Fix and improve type safety, const correctness, readability. [PWGHF] Utils: Fix and improve type safety, const correctness, readability. Aug 14, 2025
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fgrosa fgrosa enabled auto-merge (squash) August 14, 2025 17:35
@fgrosa fgrosa merged commit 09d9d99 into AliceO2Group:master Aug 15, 2025
13 of 14 checks passed
@vkucera vkucera deleted the evsel-utils branch September 1, 2025 13:08
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants