[PWGHF] Implement expert comments #12555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpxrk
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
mfaggin,
mmazzilli,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
vkucera
reviewed
Aug 13, 2025
Comment on lines
+41
to
+46
| fNotElec = 0, // not electron | ||
| fDirectCharm = 1, // electrons from prompt charm hadrons | ||
| fDirectBeauty = 2, // electrons from primary beauty hadrons | ||
| fBeautyCharm = 3, // electrons from non-prompt charm hadrons | ||
| fDirectGamma = 4, // electrons from direct photon | ||
| fGammaPi0 = 5, |
Collaborator
There was a problem hiding this comment.
Please remove the f prefixes. They serve no purpose and violate the naming conventions.
Collaborator
Author
There was a problem hiding this comment.
I didn’t want to add the “f” either, but I had no choice in order to follow the lowerCamelCase rule. I was worried that "eta" might cause a conflict, but it didn't. I removed the "f" and kept the lowerCamelCase rule.
Collaborator
There was a problem hiding this comment.
These are not variables. These are enumerator values which are equivalent to compile-time constants. The relevant naming rules is here: https://rawgit.com/AliceO2Group/CodingGuidelines/master/naming_formatting.html?showone=Enumerator_Names#Enumerator_Names
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.