-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGJE] Add secondary track's contamination inside jet #12514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ematic uncertainty
|
O2 linter results: ❌ 0 errors, |
|
Error while checking build/O2Physics/o2 for edb921f at 2025-08-10 16:35: Full log here. |
| using JetTaggerQAChargedMCPJets = soa::Join<aod::ChargedMCParticleLevelJets, aod::ChargedMCParticleLevelJetConstituents, aod::ChargedMCParticleLevelJetFlavourDef>; | ||
|
|
||
| using JetTaggerhfQACharged = JetTaggerHFQA<JetTaggerQAChargedDataJets, aod::ChargedJetTags, JetTaggerQAChargedMCDJets, aod::ChargedMCDetectorLevelJetEventWeights, aod::ChargedMCDetectorLevelJetTags, JetTaggerQAChargedMCPJets, aod::ChargedMCParticleLevelJetEventWeights, aod::ChargedMCDetectorLevelJetsMatchedToChargedMCParticleLevelJets, aod::ChargedMCParticleLevelJetsMatchedToChargedMCDetectorLevelJets>; | ||
| using JetTaggerhfQaCharged = JetTaggerHFQA<JetTaggerQAChargedDataJets, aod::ChargedJetTags, JetTaggerQAChargedMCDJets, aod::ChargedMCDetectorLevelJetEventWeights, aod::ChargedMCDetectorLevelJetTags, JetTaggerQAChargedMCPJets, aod::ChargedMCParticleLevelJetEventWeights, aod::ChargedMCDetectorLevelJetsMatchedToChargedMCParticleLevelJets, aod::ChargedMCParticleLevelJetsMatchedToChargedMCDetectorLevelJets>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be more readable to name the struct JetTaggerHfQaCharged so that it's hyphenated as jet-tagger-hf-qa-charged.
I see that JetTaggerHfQaCharged is actually an instance of a JetTaggerHFQA template which makes me suspect that the resulting device name would be jet-tagger-h-f-q-a by default. Can you please check it when you run the workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to modified to remove taskName but it doesn't work.
errors occur below
adaptAnalysisTask<JetTaggerhfQaCharged>(cfgc)};
[ERROR] invalid workflow in /Users/hanseopark/alice/sw/BUILD/c5d64f62ec99e24d89636f0e2145bbbcb900277d/O2Physics/stage/bin/o2- analysis-je-jet-taggerhf-qa: Cannot use any of ,;:"'$ as DataProcessor name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to modified to remove taskName but it doesn't work. errors occur below
adaptAnalysisTask<JetTaggerhfQaCharged>(cfgc)}; [ERROR] invalid workflow in /Users/hanseopark/alice/sw/BUILD/c5d64f62ec99e24d89636f0e2145bbbcb900277d/O2Physics/stage/bin/o2- analysis-je-jet-taggerhf-qa: Cannot use any of ,;:"'$ as DataProcessor name
That looks like invalid syntax. What was the exact line you tried to compile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to modified to remove taskName but it doesn't work. errors occur below
adaptAnalysisTask<JetTaggerhfQaCharged>(cfgc)}; [ERROR] invalid workflow in /Users/hanseopark/alice/sw/BUILD/c5d64f62ec99e24d89636f0e2145bbbcb900277d/O2Physics/stage/bin/o2- analysis-je-jet-taggerhf-qa: Cannot use any of ,;:"'$ as DataProcessor nameThat looks like invalid syntax. What was the exact line you tried to compile?
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<JetTaggerhfQaCharged>(cfgc)};
}
it happen the error [ERROR] invalid workflow in /Users/hanseopark/alice/sw/BUILD/c5d64f62ec99e24d89636f0e2145bbbcb900277d/O2Physics/stage/bin/o2-analysis-je-jet-taggerhf-qa: Cannot use any of ,;:"'$ as DataProcessor name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Thanks for trying. Looks like TaskName is needed because of the template. Please use using JetTaggerHfQaCharged = ... and
adaptAnalysisTask<JetTaggerHfQaCharged>(cfgc, TaskName{"jet-tagger-hf-qa-charged"})}; // o2-linter: disable=name/o2-task (templated struct)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand then I've changed them.
If I change "jet-tagger-hf-qa-charged" I should change "jet-taggerhf-data-charged" to "jet-tagger-hf-data-charged" and "jet-taggerhf-mcd-charged" to "jet-tagger-hf-mcd-charged" in TableProducer/jetTaggerHF.cxx for uniformity. Do you think changing everything is for unity?
And what do you think about the suggestion for the “no matching function” error that occurs when there are more than 100 configurations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, it should be fixed everywhere, but let's keep the PR focused on this file only.
Concerning the number of struct members, that is a limitation in the O2 framework which you should not touch. You have to reduce the number of members or group them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood.
I am keeping "jet-taggerhf-data-charged" for now. I will change to "tagger-hf" as soon as possible.
|
Did you fix also the "no matching function" compilation errors? |
I am trying to find the reason that I don't know. I am going to comment again when I debugged. |
I modified to reduce member of structure. The number of members that fit the |
task/jettaggerHFQA.cxx
processTracksInJetsDataandprocessTracksInMCDfor secondary track's contamination inside jets for calculation of systematic uncertainty.