Skip to content

[PWGUD] add MC codes #12484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolavick merged 1 commit into from
Aug 29, 2025
Merged

[PWGUD] add MC codes #12484

rolavick merged 1 commit into from
Aug 29, 2025

Conversation

@miedema-11
Copy link
Contributor

@miedema-11 miedema-11 commented Aug 8, 2025

No description provided.

@github-actions github-actions bot added the pwgud label Aug 8, 2025
@github-actions
Copy link

github-actions bot commented Aug 8, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title add MC codes [PWGUD] add MC codes Aug 8, 2025
@vkucera vkucera marked this pull request as draft August 8, 2025 09:35
@vkucera
Copy link
Collaborator

vkucera commented Aug 8, 2025

Please test your changes locally before you make a PR.

@miedema-11 miedema-11 force-pushed the master branch 3 times, most recently from d07db15 to af55e3c Compare August 12, 2025 05:41
@miedema-11 miedema-11 marked this pull request as ready for review August 20, 2025 05:37
@miedema-11 miedema-11 requested review from a team, ddobrigk, iarsene, jgrosseo and ktf as code owners August 20, 2025 05:37
@alibuild
Copy link
Collaborator

alibuild commented Aug 20, 2025

Error while checking build/O2Physics/o2 for af55e3c at 2025-08-20 08:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12484-slc9_x86-64/0/PWGUD/Tasks/flowCumulantsUpc.cxx:795:87: error: 'kSigmaCut' was not declared in this scope; did you mean 'kSigmaPlus'?
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft August 20, 2025 06:57
@vkucera
Copy link
Collaborator

vkucera commented Aug 20, 2025 •
edited
Loading

@miedema-11 Your PR still fails the compilation! How did you test it before marking it as ready for review?

@vkucera
Copy link
Collaborator

vkucera commented Aug 20, 2025

Remove your local changes of .pre-commit-config.yaml.

@miedema-11
Copy link
Contributor Author

miedema-11 commented Aug 20, 2025

sorry, I will try again

@miedema-11 miedema-11 marked this pull request as ready for review August 25, 2025 07:50
rolavick
rolavick previously approved these changes Aug 25, 2025
View reviewed changes
@rolavick rolavick enabled auto-merge (squash) August 25, 2025 12:04
@vkucera vkucera marked this pull request as draft August 25, 2025 18:13
auto-merge was automatically disabled August 25, 2025 18:13

Pull request was converted to draft

vkucera
vkucera requested changes Aug 25, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR must not touch .pre-commit-config.yaml.

@miedema-11 miedema-11 requested a review from vkucera August 26, 2025 04:04
@miedema-11
Copy link
Contributor Author

miedema-11 commented Aug 26, 2025

Sorry for the trouble. I learned how to completely remove it this time. Thank you

@miedema-11 miedema-11 marked this pull request as ready for review August 26, 2025 04:50
@rolavick rolavick enabled auto-merge (squash) August 26, 2025 12:35
@miedema-11 miedema-11 requested a review from rolavick August 29, 2025 07:39
@miedema-11
Copy link
Contributor Author

miedema-11 commented Aug 29, 2025

Hi! It seems that all checks have passed, could you please merge it for me. Thank you

@rolavick rolavick merged commit b21b55e into AliceO2Group:master Aug 29, 2025
14 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@miedema-11 @jinhyunni
[PWGUD] add MC codes (AliceO2Group#12484)
043804a
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@miedema-11 @ThePhDane
[PWGUD] add MC codes (AliceO2Group#12484)
9f88632
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@miedema-11 @jloemker
[PWGUD] add MC codes (AliceO2Group#12484)
fe97122
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@miedema-11
[PWGUD] add MC codes (AliceO2Group#12484)
64b08b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolavick rolavick rolavick approved these changes

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler

@jgrosseo jgrosseo Awaiting requested review from jgrosseo

@iarsene iarsene Awaiting requested review from iarsene

@ktf ktf Awaiting requested review from ktf

@ddobrigk ddobrigk Awaiting requested review from ddobrigk

Assignees

No one assigned

Labels

pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miedema-11 @vkucera @alibuild @rolavick