Skip to content

[PWGCF] jFlucEfficiencyTask - Add high pT tracks study functionalities #12453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BongHwi merged 8 commits into from
Aug 6, 2025
Merged

[PWGCF] jFlucEfficiencyTask - Add high pT tracks study functionalities #12453

BongHwi merged 8 commits into from
Aug 6, 2025

Conversation

@BongHwi
Copy link
Collaborator

@BongHwi BongHwi commented Aug 6, 2025

Adding some study histograms used to check the pT resolution, mismatching of the charge, and TPC-A,C side results.

@github-actions github-actions bot added the pwgcf label Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Aug 6, 2025
Merged
@alibuild alibuild mentioned this pull request Aug 6, 2025
Merged
@BongHwi
Merge pull request #33 from alibuild/alibot-cleanup-12453
6c8dfb7 
Please consider the following formatting changes to AliceO2Group#12453
@BongHwi BongHwi enabled auto-merge (squash) August 6, 2025 06:28
victor-gonzalez
victor-gonzalez requested changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't create pull request that don't compile
Changes should compile and pass local tests before before requiring rising a PR

@BongHwi
Copy link
Collaborator Author

BongHwi commented Aug 6, 2025

Hello @victor-gonzalez ,
I'm sorry that I overlooked the last update..
Now, there is no issue on the build.

@BongHwi BongHwi requested a review from victor-gonzalez August 6, 2025 08:37
@alibuild
Copy link
Collaborator

alibuild commented Aug 6, 2025

Error while checking build/O2Physics/o2 for 6c8dfb7 at 2025-08-06 11:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12453-slc9_x86-64/0/PWGCF/JCorran/Tasks/jFlucEfficiencyTask.cxx:52:3: error: non-static data member 'kChargeThreshold' declared 'constexpr'
ninja: build stopped: subcommand failed.

Full log here.

@BongHwi BongHwi enabled auto-merge (squash) August 6, 2025 11:56
alibuild
alibuild approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @BongHwi.

@BongHwi BongHwi merged commit dc92ed4 into AliceO2Group:master Aug 6, 2025
13 checks passed
@BongHwi BongHwi deleted the JCorEffiStudy branch August 7, 2025 07:49
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
@BongHwi @alibuild @jpxrk
[PWGCF] jFlucEfficiencyTask - Add high pT tracks study functionalities (
8253687 
AliceO2Group#12453)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
GijsvWeelden pushed a commit to GijsvWeelden/O2Physics that referenced this pull request Aug 14, 2025
@BongHwi @alibuild @GijsvWeelden
[PWGCF] jFlucEfficiencyTask - Add high pT tracks study functionalities (
9188266 
AliceO2Group#12453)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@BongHwi @alibuild @jloemker
[PWGCF] jFlucEfficiencyTask - Add high pT tracks study functionalities (
cc02c9c 
AliceO2Group#12453)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@BongHwi @alibuild
[PWGCF] jFlucEfficiencyTask - Add high pT tracks study functionalities (
4719d00 
AliceO2Group#12453)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild alibuild approved these changes

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BongHwi @alibuild @victor-gonzalez