[PWGHF] Add D*pi channel in B0 reduced workflow #12451
Conversation
|
O2 linter results: ❌ 4 errors, |
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#12451
Marcellocosti
force-pushed
the
B0ToDstar
branch
from
99acfba to
5911f24
Compare
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @Marcellocosti, thanks for the development!
I have a comment about the data structure. I would not call the "Dstar" table "Dstar", since it contains basically D0 features. Also, there is some duplication of information that is not necessary, and you can handle a bit better. See my comments below, if you need clarifications let me know!
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
Thanks @Marcellocosti for addressing my comments.
Approving to not block the review by @fgrosa .
Please consider the following formatting changes to AliceO2Group#12451
| hf_cand::E<hf_cand_2prong::Px, hf_cand_2prong::Py, hf_cand_2prong::Pz>, | ||
| hf_cand::E2<hf_cand_2prong::Px, hf_cand_2prong::Py, hf_cand_2prong::Pz>); | ||
|
|
||
| DECLARE_SOA_TABLE(HfCandB0DStar, "AOD", "HFCANDB0DSTAR", |
There was a problem hiding this comment.
This table seems produced only by candidateCreatorB0Reduced.cxx. Why is it defined in the main data model?
There was a problem hiding this comment.
I thought it would be clearer to have this table declared close to HfCandB0Base (table for the D-pi channel) since it is its respective table for the D*Pi channel.
There was a problem hiding this comment.
Hi @vkucera I think it's good to keep it there for 2 reasons:
- consistency with the other channels
- in the future this channel might be considered to be added in the "non reduced" workflow, for instance if there will be an interest to include it in the HF-jet analyses (in principle we expect this to have more or less the same performance as
B0 -> D-pi+)
PWGHF/Core/HfMlResponseB0ToDPi.h
Outdated
| #define PWGHF_CORE_HFMLRESPONSEB0TODPI_H_ | ||
|
|
||
| #include "PWGHF/Core/HfMlResponse.h" | ||
| #include "PWGHF/D2H/DataModel/ReducedDataModel.h" |
There was a problem hiding this comment.
I added this header as later in the same file I retrieve the soft pion of the D*, using the tables declared in ReducedDataModel.h with the line
auto prongSoftPi = candidate.template prongSoftPi_as<o2::soa::Join<o2::aod::HfRedSoftPiBases, o2::aod::HfRedSoftPiCov, o2::aod::HfRedSoftPiPid>>();
Please consider the following formatting changes to AliceO2Group#12451
Marcellocosti
requested review from
NicoleBastid,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli and
zhangbiao-phy
as code owners
Thanks @Marcellocosti, it's good for me now! |
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
4 participants
This PR adds the D* pi final state for the B0 meson in the reduced workflow. Separate tables and functions have been created for D*, please let me know if you prefer other solutions.