[PWGHF,PWGJE] Add D* spin alignment jet analysis task #12436

Mingze129 · 2025-08-05T11:26:43Z

For now, the task include data and Reco-level MC analysis only.

github-actions · 2025-08-05T11:26:58Z

O2 linter results: ❌ 3 errors, ⚠️ 1 warnings, 🔕 3 disabled

Please consider the following formatting changes to AliceO2Group#12436

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

vkucera · 2025-09-08T09:58:42Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+  template <charm_polarisation::DecayChannel channel, bool withMl, bool doMc, typename Jet, typename Cand>
+  bool runPolarisationAnalysis(Jet const& jet, Cand const& candidate, int bkgRotationId)
+  {


Why is channel a template argument?

I have removed channel from the templated argument list.

How about others? like withMl and doMc, should I move them as well？

I don't think you can remove them in this case, because you need the flagMcMatchRec, mlScores columns whose availability depends on the table subscriptions.

Is it fine now?

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

vkucera · 2025-09-08T11:22:44Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+          threeVecCand = RecoDecay::pVec(std::array{candidate.pxProng1(), candidate.pyProng1(), candidate.pzProng1()},
+                                         std::array{candidate.pyProng0Charm(), candidate.pxProng0Charm(), candidate.pzProng0Charm()},
+                                         std::array{candidate.pxProng1Charm(), candidate.pyProng1Charm(), candidate.pzProng1Charm()});


Why don't you use the candidate momentum directly?

Use candidate momentum directly now.

vkucera · 2025-09-08T14:53:41Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+  void fillRecoHistos(charm_polarisation::CosThetaStarType cosThetaStarType, float invMassCharmHad, float ptCharmHad, float rapCharmHad, float invMassD0, float cosThetaStar, const std::array<float, 3>& outputMl, int isRotatedCandidate, int8_t origin, float ptBhadMother, float absEtaMin, int numItsClsMin, int numTpcClsMin, int8_t nMuons, bool isPartRecoDstar, float zParallel, float jetPt)
+  {


The amount of parameters makes the function calls super error-prone.
It would be much safer to pass a const& to a single object, like a struct or a map.
Even better would be to remove the function completely by simplifying the body.

I would keep fillRecoHistos since it is called several times for different cases (also in view to extend the task to other particles, such as Lc, it would be good to keep it

Use struct pass parameters.

github-actions · 2025-10-24T01:45:48Z

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

Please consider the following formatting changes to AliceO2Group#12436

Mingze129 · 2025-10-27T11:30:47Z

@vkucera I have updated the code, Could you please review it again when you are free?

vkucera · 2025-11-12T16:49:03Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+  /// \param numTpcClsMin is the minimum number of TPC clusters of the daughter tracks
+  /// \param nMuons is the number of muons from daughter decays
+  /// \param isPartRecoDstar is a flag indicating if it is a partly reconstructed Dstar meson (MC only)
+  void fillRecoHistos(charm_polarisation::CosThetaStarType cosThetaStarType, bool withMl, bool doMc, bool isPartRecoDstar, HfHistoInput& recoHistoInput)


Suggested change

void fillRecoHistos(charm_polarisation::CosThetaStarType cosThetaStarType, bool withMl, bool doMc, bool isPartRecoDstar, HfHistoInput& recoHistoInput)

void fillRecoHistos(charm_polarisation::CosThetaStarType cosThetaStarType, bool withMl, bool doMc, bool isPartRecoDstar, HfHistoInput const& recoHistoInput)

vkucera · 2025-11-12T16:49:27Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+  /// \param invMassCharmHad is the invariant-mass of the candidate
+  /// \param ptCharmHad is the pt of the candidate
+  /// \param rapCharmHad is the rapidity of the candidate
+  /// \param invMassD0 is the invariant-mass of the D0 daugher (only for D*+)
+  /// \param cosThetaStar is the cosThetaStar of the candidate
+  /// \param outputMl is the array with ML output scores
+  /// \param isRotatedCandidate is a flag that keeps the info of the rotation of the candidate for bkg studies
+  /// \param origin is the MC origin
+  /// \param ptBhadMother is the pt of the b-hadron mother (only in case of non-prompt)
+  /// \param absEtaMin is the minimum absolute eta of the daughter tracks
+  /// \param numItsClsMin is the minimum number of ITS clusters of the daughter tracks
+  /// \param numTpcClsMin is the minimum number of TPC clusters of the daughter tracks
+  /// \param nMuons is the number of muons from daughter decays
+  /// \param isPartRecoDstar is a flag indicating if it is a partly reconstructed Dstar meson (MC only)


Update the documentation

vkucera · 2025-11-12T16:51:27Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+      }
+      if (activateTHnSparseCosThStarHelicity) {
+        // helicity
+        cosThetaStarHelicity = helicityVec.Dot(threeVecDauCM) / std::sqrt(threeVecDauCM.Mag2()) / std::sqrt(helicityVec.Mag2());


You only need one sqrt.

vkucera · 2025-11-12T16:58:18Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+  Configurable<float> minRotAngleMultByPi{"minRotAngleMultByPi", 5. / 6, "Minimum angle rotation for track rotation, to be multiplied by pi"};
+  Configurable<float> maxRotAngleMultByPi{"maxRotAngleMultByPi", 7. / 6, "Maximum angle rotation for track rotation, to be multiplied by pi"};


Put the attributes Min, Max at the end.

The name suggests that the value is the product of the rotation angle and Pi, however the help string suggests that it is the ratio of the angle and Pi.

You define a default value for a float as double/int. Make it consistent.

vkucera · 2025-11-12T17:00:55Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+        std::array<float, 3> threeVecSoftPi{candidate.pxProng1() * std::cos(bkgRotAngle) - candidate.pyProng1() * std::sin(bkgRotAngle), candidate.pxProng1() * std::sin(bkgRotAngle) + candidate.pyProng1() * std::cos(bkgRotAngle), candidate.pzProng1()}; // we rotate the soft pion
+        std::array<float, 3> threeVecD0Prong0{candidate.pxProng0Charm(), candidate.pyProng0Charm(), candidate.pzProng0Charm()};
+        std::array<float, 3> threeVecD0Prong1{candidate.pxProng1Charm(), candidate.pyProng1Charm(), candidate.pzProng1Charm()};


The scope is wrong. These are used only inside the if (bkgRotationId > 0) block.

vkucera · 2025-11-12T17:01:25Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+        std::array<float, 3> threeVecSoftPi{candidate.pxProng1() * std::cos(bkgRotAngle) - candidate.pyProng1() * std::sin(bkgRotAngle), candidate.pxProng1() * std::sin(bkgRotAngle) + candidate.pyProng1() * std::cos(bkgRotAngle), candidate.pzProng1()}; // we rotate the soft pion
+        std::array<float, 3> threeVecD0Prong0{candidate.pxProng0Charm(), candidate.pyProng0Charm(), candidate.pzProng0Charm()};
+        std::array<float, 3> threeVecD0Prong1{candidate.pxProng1Charm(), candidate.pyProng1Charm(), candidate.pzProng1Charm()};


Suggested change

std::array<float, 3> threeVecSoftPi{candidate.pxProng1() * std::cos(bkgRotAngle) - candidate.pyProng1() * std::sin(bkgRotAngle), candidate.pxProng1() * std::sin(bkgRotAngle) + candidate.pyProng1() * std::cos(bkgRotAngle), candidate.pzProng1()}; // we rotate the soft pion

std::array<float, 3> threeVecD0Prong0{candidate.pxProng0Charm(), candidate.pyProng0Charm(), candidate.pzProng0Charm()};

std::array<float, 3> threeVecD0Prong1{candidate.pxProng1Charm(), candidate.pyProng1Charm(), candidate.pzProng1Charm()};

const std::array threeVecSoftPi{candidate.pxProng1() * std::cos(bkgRotAngle) - candidate.pyProng1() * std::sin(bkgRotAngle), candidate.pxProng1() * std::sin(bkgRotAngle) + candidate.pyProng1() * std::cos(bkgRotAngle), candidate.pzProng1()}; // we rotate the soft pion

const std::array threeVecD0Prong0{candidate.pxProng0Charm(), candidate.pyProng0Charm(), candidate.pzProng0Charm()};

const std::array threeVecD0Prong1{candidate.pxProng1Charm(), candidate.pyProng1Charm(), candidate.pzProng1Charm()};

vkucera · 2025-11-12T17:03:04Z

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx

+  /// \param candidates are the selected candidates
+  /// \param bkgRotationId is the id for the background rotation
+  /// \return true if candidate in signal region
+  template <bool withMl, bool doMc, typename Jet, typename Cand>


Suggested change

template <bool withMl, bool doMc, typename Jet, typename Cand>

template <bool WithMl, bool DoMc, typename Jet, typename Cand>

vkucera · 2025-11-12T17:05:01Z

PWGHF/HFJ/CMakeLists.txt

-# or submit itself to any jurisdiction.
+# or submit itself to any jurisdiction.
+
+add_subdirectory(Tasks)


I think in the end the new task should go in the PWGJE directory, since it's input are JE tables.

github-actions · 2025-12-13T01:55:36Z

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

Mingze129 added 3 commits August 4, 2025 10:13

first try

c29613e

data should be fine but mc....

2800c82

data and Reco Mc only

c67f901

github-actions bot added pwghf PWG-HF datamodel labels Aug 5, 2025

github-actions bot changed the title ~~Adding Dstar spin alignment in jet analysis task~~ [PWGHF] Adding Dstar spin alignment in jet analysis task Aug 5, 2025

Mingze129 changed the title ~~[PWGHF] Adding Dstar spin alignment in jet analysis task~~ [PWGHF] Adding Dstar spin alignment in jet analysis task Aug 5, 2025

Please consider the following formatting changes

516243c

alibuild mentioned this pull request Aug 5, 2025

Please consider the following formatting changes to #12436 Mingze129/O2Physics#20

Merged

Mingze129 and others added 3 commits August 5, 2025 13:28

Merge pull request #20 from alibuild/alibot-cleanup-12436

0eab99f

Please consider the following formatting changes to AliceO2Group#12436

update

ad676a6

updating jet derived data producer

7a6fb05

github-actions bot added the pwgje label Aug 5, 2025

Mingze129 changed the title ~~[PWGHF] Adding Dstar spin alignment in jet analysis task~~ [PWGHF，PWGJE] Adding Dstar spin alignment in jet analysis task Aug 5, 2025

Mingze129 changed the title ~~[PWGHF，PWGJE] Adding Dstar spin alignment in jet analysis task~~ [PWGHF, PWGJE] Adding Dstar spin alignment in jet analysis task Aug 5, 2025

github-actions bot changed the title ~~[PWGHF, PWGJE] Adding Dstar spin alignment in jet analysis task~~ [PWGHF,PWGJE] [PWGHF，PWGJE] Adding Dstar spin alignment in jet analysis task Aug 5, 2025

github-actions bot changed the title ~~[PWGHF,PWGJE] [PWGHF，PWGJE] Adding Dstar spin alignment in jet analysis task~~ [PWGHF,PWGJE] Adding Dstar spin alignment in jet analysis task Aug 5, 2025

Mingze129 added 5 commits August 5, 2025 14:07

fixing O2 Linter error

62e108d

update

9720849

update

775dbbe

change the name of main struct

745c58a

update

4595da2

Mingze129 marked this pull request as ready for review August 5, 2025 12:50

Mingze129 requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern and nzardosh as code owners August 5, 2025 12:50

update

ce1b31b

vkucera reviewed Sep 5, 2025

View reviewed changes

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx Outdated Show resolved Hide resolved

update

349f5bf

vkucera reviewed Sep 8, 2025

View reviewed changes

PWGHF/HFJ/Tasks/taskDstarPolarisationInJet.cxx Outdated Show resolved Hide resolved

update

6f2df99

vkucera reviewed Sep 8, 2025

View reviewed changes

github-actions bot added the stale label Oct 24, 2025

Mingze129 added 2 commits October 27, 2025 11:12

new update

f76894e

use lowerCamelCase

9878b6a

alibuild mentioned this pull request Oct 27, 2025

Please consider the following formatting changes to #12436 Mingze129/O2Physics#23

Merged

alibuild and others added 2 commits October 27, 2025 11:19

Please consider the following formatting changes

a04eb65

Merge pull request #23 from alibuild/alibot-cleanup-12436

28bb7de

Please consider the following formatting changes to AliceO2Group#12436

github-actions bot removed the stale label Oct 28, 2025

Merge branch 'master' into jetdstar

be51264

Mingze129 requested a review from vkucera October 30, 2025 10:22

vkucera reviewed Nov 12, 2025

View reviewed changes

github-actions bot added the stale label Dec 13, 2025

github-actions bot closed this Dec 18, 2025

		void fillRecoHistos(charm_polarisation::CosThetaStarType cosThetaStarType, float invMassCharmHad, float ptCharmHad, float rapCharmHad, float invMassD0, float cosThetaStar, const std::array<float, 3>& outputMl, int isRotatedCandidate, int8_t origin, float ptBhadMother, float absEtaMin, int numItsClsMin, int numTpcClsMin, int8_t nMuons, bool isPartRecoDstar, float zParallel, float jetPt)
		{

		Configurable<float> minRotAngleMultByPi{"minRotAngleMultByPi", 5. / 6, "Minimum angle rotation for track rotation, to be multiplied by pi"};
		Configurable<float> maxRotAngleMultByPi{"maxRotAngleMultByPi", 7. / 6, "Maximum angle rotation for track rotation, to be multiplied by pi"};

	template <bool withMl, bool doMc, typename Jet, typename Cand>
	template <bool WithMl, bool DoMc, typename Jet, typename Cand>

[PWGHF,PWGJE] Add D* spin alignment jet analysis task #12436

[PWGHF,PWGJE] Add D* spin alignment jet analysis task #12436

Uh oh!

Conversation

Mingze129 commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vkucera Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vkucera Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

Mingze129 commented Oct 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vkucera Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Aug 5, 2025 •

edited

Loading

vkucera Sep 8, 2025 •

edited

Loading

vkucera Sep 8, 2025 •

edited

Loading

vkucera Nov 12, 2025 •

edited

Loading