[PWGJE,EMCAL-1154] Core/emcalCrossTalEmulation: fix cell ID outside li… #12419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mits bug - Fix `Exception while running: Cell ID 17665 outside limits.. Rethrowing.`. This exception was triggered, because the EMCal constants `EMCAL_ROWS` and `EMCAL_COLS` are only valid for full EMCal SM. However, the EMCal does also have 1/3 and 2/3 SM where either the number of rows or columns can be smaller, making checks onlt work for full SM. For now this fix is locally done in the class for the corsstalkemulation. A general fix in O2 should be considered.
mhemmer-cern
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa and
nzardosh
as code owners
|
O2 linter results: ❌ 0 errors, |
Collaborator
Author
|
Straight forward bugfix, will self approve to get this online fast. |
alibuild
approved these changes
Aug 4, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
mhemmer-cern
changed the title
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Aug 12, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mits bug
Exception while running: Cell ID 17665 outside limits.. Rethrowing.. This exception was triggered, because the EMCal constantsEMCAL_ROWSandEMCAL_COLSare only valid for full EMCal SM. However, the EMCal does also have 1/3 and 2/3 SM where either the number of rows or columns can be smaller, making checks onlt work for full SM. For now this fix is locally done in the class for the corsstalkemulation. A general fix in O2 should be considered.