[PWGEM] PhotonMeson/Tasks/compconvbuilder: Fix linter and includes #12410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing includes using the IWYU principle
- Remove unused includes
- Fix O2Linter errors, except one magic number error, which was silenced: `if (daughters.size() != 2)`. This one is not a magic number imo.
- Fix include parenthese for ("outside") O2 headers
mhemmer-cern
requested review from
alibuild,
dsekihat,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
|
O2 linter results: ❌ 0 errors, |
mhemmer-cern
changed the title
alibuild
approved these changes
Aug 4, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Aug 12, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (daughters.size() != 2). This one is not a magic number imo.