Skip to content

[PWGLF] Fix histogram axis names + add different encoding options #12409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romainschotter merged 6 commits into from
Aug 7, 2025
Merged

[PWGLF] Fix histogram axis names + add different encoding options #12409

romainschotter merged 6 commits into from
Aug 7, 2025

Conversation

@romainschotter
Copy link
Collaborator

@romainschotter romainschotter commented Aug 3, 2025

No description provided.

@github-actions github-actions bot added the pwglf label Aug 3, 2025
@github-actions github-actions bot changed the title Fix histogram axis names + add different encoding options [PWGLF] Fix histogram axis names + add different encoding options Aug 3, 2025
@github-actions
Copy link

github-actions bot commented Aug 3, 2025 •
edited
Loading

O2 linter results: ❌ 64 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Aug 3, 2025
Merged
@romainschotter
Merge pull request #51 from alibuild/alibot-cleanup-12409
93d8f08 
[PWGLF] Please consider the following formatting changes to AliceO2Group#12409
@romainschotter romainschotter marked this pull request as ready for review August 3, 2025 21:34
@romainschotter romainschotter enabled auto-merge (squash) August 3, 2025 21:34
alibuild
alibuild previously approved these changes Aug 3, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild
Copy link
Collaborator

alibuild commented Aug 4, 2025

Error while checking build/O2Physics/o2 for 93d8f08 at 2025-08-04 02:12:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12409-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx:270:69: error: unused parameter 'clampMin' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12409-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx:270:83: error: unused parameter 'clampMax' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12409-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx:805:81: error: operation on 'decayRadius' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/12409-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessderivedbinnedinfo.cxx:827:81: error: operation on 'decayRadius' may be undefined [-Werror=sequence-point]
ninja: build stopped: subcommand failed.

Full log here.

@romainschotter romainschotter merged commit 9a02de3 into AliceO2Group:master Aug 7, 2025
11 of 12 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
@romainschotter @alibuild @jpxrk
[PWGLF] Fix histogram axis names + add different encoding options (Al…
ea02f76 
…iceO2Group#12409)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
GijsvWeelden pushed a commit to GijsvWeelden/O2Physics that referenced this pull request Aug 14, 2025
@romainschotter @alibuild @GijsvWeelden
[PWGLF] Fix histogram axis names + add different encoding options (Al…
497d530 
…iceO2Group#12409)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@romainschotter @alibuild @jloemker
[PWGLF] Fix histogram axis names + add different encoding options (Al…
e3eaa3e 
…iceO2Group#12409)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@romainschotter @alibuild
[PWGLF] Fix histogram axis names + add different encoding options (Al…
61eb2cb 
…iceO2Group#12409)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skundu692 skundu692 skundu692 approved these changes

@alibuild alibuild alibuild left review comments

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romainschotter @alibuild @skundu692