Skip to content

[PWGLF,Trigger] Update tofpidgeneric for secondary tracks to use TOFResoParamsV3 #12395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maciacco merged 5 commits into from
Aug 3, 2025
Merged

[PWGLF,Trigger] Update tofpidgeneric for secondary tracks to use TOFResoParamsV3 #12395

maciacco merged 5 commits into from
Aug 3, 2025

Conversation

@wang-yuanzhe
Copy link
Contributor

@wang-yuanzhe wang-yuanzhe commented Aug 2, 2025 •
edited
Loading

This PR updates the tofpidgeneric workflow (works for secondary tracks which are assigned to a wrong collision) to use TOFResoParamsV3 instead of TOFResoParamsV2

  1. The definitions in the old header file (PWGLF/DataModel/pidTOFGeneric.h) have been split into two separate files: one in the DataModel (PWGLF/DataModel/LFPIDTOFGenericTables.h) and one in the Utils (PWGLF/Utils/pidTOFGeneric.h).
  2. All tasks that use or include tofpidgeneric have been updated accordingly
  3. For event filtering, the TOF PID cut is disabled by default, so this change will not affect the filtering results.
  4. Add recalculated tof pid in hyperkinkRecoTask

@github-actions
Copy link

github-actions bot commented Aug 2, 2025 •
edited
Loading

O2 linter results: ❌ 113 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update generic TOFPID for secondary tracks to use TOFResoParamsV3 [PWGLF,Trigger] Update generic TOFPID for secondary tracks to use TOFResoParamsV3 Aug 2, 2025
@alibuild alibuild mentioned this pull request Aug 2, 2025
Merged
@wang-yuanzhe wang-yuanzhe changed the title [PWGLF,Trigger] Update generic TOFPID for secondary tracks to use TOFResoParamsV3 [PWGLF,Trigger] Update tofpidgeneric for secondary tracks to use TOFResoParamsV3 Aug 2, 2025
@maciacco maciacco enabled auto-merge (squash) August 2, 2025 19:16
@maciacco maciacco merged commit 5a007a9 into AliceO2Group:master Aug 3, 2025
14 of 15 checks passed
@wang-yuanzhe wang-yuanzhe deleted the secondary_tofpid branch August 3, 2025 08:02
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
@wang-yuanzhe @alibuild @jpxrk
[PWGLF,Trigger] Update tofpidgeneric for secondary tracks to use TOFR…
3ec5203 
…esoParamsV3 (AliceO2Group#12395)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@wang-yuanzhe @alibuild @jloemker
[PWGLF,Trigger] Update tofpidgeneric for secondary tracks to use TOFR…
3de8a52 
…esoParamsV3 (AliceO2Group#12395)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@wang-yuanzhe @alibuild
[PWGLF,Trigger] Update tofpidgeneric for secondary tracks to use TOFR…
8fe279a 
…esoParamsV3 (AliceO2Group#12395)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpuccio mpuccio mpuccio approved these changes

@maciacco maciacco maciacco approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

@ChiaraDeMartin95 ChiaraDeMartin95 Awaiting requested review from ChiaraDeMartin95 ChiaraDeMartin95 is a code owner

@lietava lietava Awaiting requested review from lietava lietava is a code owner

Assignees

No one assigned

Labels

datamodel pwglf trigger

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wang-yuanzhe @mpuccio @maciacco @alibuild