Skip to content

Conversation

@kaareendrup
Copy link
Contributor

This PR fixes the same issue as #11478 but for the efficiency task.

A check is added for the geometry similar to the one in AnalysisSameEventPairing tasks, along with the required configurables.

@github-actions
Copy link

github-actions bot commented Jul 31, 2025

O2 linter results: ❌ 103 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add geometry loading to dilepton-track task [PWGDQ] Add geometry loading to dilepton-track task Jul 31, 2025
mcoquet642
mcoquet642 previously approved these changes Jul 31, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 32e0959 at 2025-07-31 16:16:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1084:9: error: expected primary-expression before '->' token
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1085:9: error: expected primary-expression before '->' token
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1086:9: error: expected primary-expression before '->' token
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1092:13: error: expected primary-expression before '->' token
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1092:30: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1095:7: error: 'lut' was not declared in this scope
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1095:62: error: expected primary-expression before '->' token
/sw/SOURCES/O2Physics/12355-slc9_x86-64/0/PWGDQ/Tasks/dqEfficiency.cxx:1095:92: error: expected primary-expression before '>' token
ninja: build stopped: subcommand failed.

Full log here.

@mcoquet642 mcoquet642 self-requested a review July 31, 2025 14:19
Define ccdb and lut
@mcoquet642 mcoquet642 merged commit 8336967 into AliceO2Group:master Aug 1, 2025
11 of 12 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants