[PWGJE] Fixed 3D histogram filling #12332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindkhuntia
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 93 errors, |
nzardosh
approved these changes
Jul 30, 2025
Collaborator
|
Hi @arvindkhuntia , you have plenty of hypotenuse calculations. Consider using existing features like |
Collaborator
|
Also consider fixing the errors. |
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Aug 12, 2025
Co-authored-by: Arvind Khuntia <arvind.khuntia@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Co-authored-by: Arvind Khuntia <arvind.khuntia@cern.ch>
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Co-authored-by: Arvind Khuntia <arvind.khuntia@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @nzardosh,
This PR just fixed the 3D histogram filling. Please approve the PR once tests are done.
Have a nice day.