[Common,PWGLF] Expose configurables inside TrackTuner in propagationService #12306
Conversation
ddobrigk
requested review from
a team,
alibuild,
ercolessi,
iarsene,
jgrosseo,
ktf,
romainschotter and
skundu692
as code owners
|
O2 linter results: ❌ 6 errors, |
| template <typename TConfigurableGroup, typename TTrackTuner, typename TInitContext, typename THistoRegistry> | ||
| void init(TConfigurableGroup const& cGroup, TTrackTuner& trackTunerObj, THistoRegistry& registry, TInitContext& initContext) |
There was a problem hiding this comment.
trackTunerObjis unused.- Why is it passed by non-const reference?
- Why is the type templated?
There was a problem hiding this comment.
Hi @vkucera, it's definitely used, please check again by looking at the actual code and not just the changelog. I can pass it as const and I can also explicitly mention the type - there, you're right, I'll adjust.
There was a problem hiding this comment.
Ah, sorry, I overlooked the line that removes the member from the class.
There was a problem hiding this comment.
I changed such that the type is not a template. However: the non-const reference I cannot avoid - there are further function calls in the track tuner that are not marked as const and then it does not compile. There may be further adjustments needed to the track tuner anyhow - I think it's best to leave this for future improvements of the trackTuner tool.
There was a problem hiding this comment.
OK, fair enough. Thanks for trying though.
vkucera
changed the title
|
Please add the missing header includes. |
…ervice (AliceO2Group#12306) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
…ervice (AliceO2Group#12306) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
…ervice (AliceO2Group#12306) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
4 participants
Since the tracktuner class derives from ConfigurableGroups, it has to be put in the analysis task itself for the relevant configurables to be exposed directly to the user of a joint service such as propagationService.