[PWGEM,PWGEM-8] Clean up of PhotonMeson #12296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhemmer-cern
requested review from
alibuild,
dsekihat,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
|
O2 linter results: ❌ 385 errors, |
alibuild
previously approved these changes
Jul 28, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
- Remove gammaSelection.cxx, gammaSelectionCuts.h and produceMesonCalo.cxx since they were not used - Remove many old tables that were unused - Update `SkimEMCClusters` table to use the new DeltaEta und DeltaPhi columns coming from the emcalCorrectionTask for better TM. - Update histogram libs and cut libs according to the change above - Fix includes according to IWYU for all touched files
alibuild
approved these changes
Jul 28, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
vkucera
reviewed
Jul 29, 2025
Comment on lines
+35
to
+36
| fRegistry->add("Cluster/before/hE", "E_{cluster};#it{E}_{cluster} (GeV);#it{N}_{cluster}", o2::framework::kTH1F, {{500, 0.0f, 50}}, true); | ||
| fRegistry->add("Cluster/before/hPt", "Transverse momenta of clusters;#it{p}_{T} (GeV/c);#it{N}_{cluster}", o2::framework::kTH1F, {{500, 0.0f, 50}}, true); |
Collaborator
There was a problem hiding this comment.
Thanks for preparing the removal of the using directive. 👍🏻
Collaborator
Author
There was a problem hiding this comment.
Small steps 😄
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Aug 12, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkimEMCMTs,SkimGammas,SkimPCMCuts,SkimPHOSCuts,SkimEMCCuts)SkimEMCClusterstable to use the new DeltaEta und DeltaPhi columns coming from the emcalCorrectionTask for better TM.SkimEMCClustersto be in all caps and without thes(SKIMEMCCLUSTER)