-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGLF] Added signal/event loss corrections #12293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 0 errors, |
|
@sawankumawat please fix o2linter error |
The only o2linter error is "Assign the value to a clearly named variable or constant". But then I have to create many variables in the code at every place, which will not look good. @vkucera Please suggest |
Hi @sawankumawat @dmallick2 , you are not supposed to "create many variables in the code at every place", on the contrary, you are supposed to define a few meaningful variables to replace the hard-coded numbers. In your case, it seems you only need a constant for the rapidity cut and for the number of daughters. Btw, you have 4 other categories of errors which should also be fixed. You are hard-coding masses and PDG codes and reinventing the phi range constraints. Please use the existing functionalities as the linter suggests. |
Head branch was pushed to by a user without write access
Hi @vkucera Thank you for the suggestion. I have solved all the linter errors now. |
|
Error while checking build/O2Physics/o2 for b5bba79 at 2025-07-29 09:57: Full log here. |
|
@dmallick2 @vkucera I think now all the things are resolved. Thanks for your help. Please approve and enable auto merging. |
|
@sawankumawat Thanks for implementing the comments. |
Co-authored-by: Sawan Sawan <sawan.sawan@cern.ch>
Co-authored-by: Sawan Sawan <sawan.sawan@cern.ch>
Co-authored-by: Sawan Sawan <sawan.sawan@cern.ch>
No description provided.