Skip to content

Conversation

@sawankumawat
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@dmallick2
Copy link
Collaborator

@sawankumawat please fix o2linter error

@sawankumawat
Copy link
Contributor Author

@sawankumawat please fix o2linter error

The only o2linter error is "Assign the value to a clearly named variable or constant". But then I have to create many variables in the code at every place, which will not look good. @vkucera Please suggest

dmallick2
dmallick2 previously approved these changes Jul 28, 2025
@dmallick2 dmallick2 enabled auto-merge (squash) July 28, 2025 19:47
@vkucera
Copy link
Collaborator

vkucera commented Jul 28, 2025

@sawankumawat please fix o2linter error

The only o2linter error is "Assign the value to a clearly named variable or constant". But then I have to create many variables in the code at every place, which will not look good. @vkucera Please suggest

Hi @sawankumawat @dmallick2 , you are not supposed to "create many variables in the code at every place", on the contrary, you are supposed to define a few meaningful variables to replace the hard-coded numbers. In your case, it seems you only need a constant for the rapidity cut and for the number of daughters.

Btw, you have 4 other categories of errors which should also be fixed. You are hard-coding masses and PDG codes and reinventing the phi range constraints. Please use the existing functionalities as the linter suggests.

auto-merge was automatically disabled July 29, 2025 07:04

Head branch was pushed to by a user without write access

@sawankumawat
Copy link
Contributor Author

@sawankumawat please fix o2linter error

The only o2linter error is "Assign the value to a clearly named variable or constant". But then I have to create many variables in the code at every place, which will not look good. @vkucera Please suggest

Hi @sawankumawat @dmallick2 , you are not supposed to "create many variables in the code at every place", on the contrary, you are supposed to define a few meaningful variables to replace the hard-coded numbers. In your case, it seems you only need a constant for the rapidity cut and for the number of daughters.

Btw, you have 4 other categories of errors which should also be fixed. You are hard-coding masses and PDG codes and reinventing the phi range constraints. Please use the existing functionalities as the linter suggests.

Hi @vkucera Thank you for the suggestion. I have solved all the linter errors now.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for b5bba79 at 2025-07-29 09:57:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12293-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:1383:36: error: comparison of integer expressions of different signedness: 'std::vector<bool>::size_type' {aka 'long unsigned int'} and 'std::array<int, 6>::value_type' {aka 'int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/12293-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:1388:25: error: comparison of integer expressions of different signedness: 'std::vector<bool>::size_type' {aka 'long unsigned int'} and 'std::array<int, 6>::value_type' {aka 'int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@sawankumawat
Copy link
Contributor Author

sawankumawat commented Jul 29, 2025

@dmallick2 @vkucera I think now all the things are resolved. Thanks for your help. Please approve and enable auto merging.
Thank you

@dmallick2 dmallick2 enabled auto-merge (squash) July 29, 2025 09:44
@vkucera
Copy link
Collaborator

vkucera commented Jul 29, 2025

@sawankumawat Thanks for implementing the comments.

@dmallick2 dmallick2 disabled auto-merge July 29, 2025 12:56
@dmallick2 dmallick2 enabled auto-merge (squash) July 29, 2025 12:56
@dmallick2 dmallick2 disabled auto-merge July 29, 2025 21:25
@dmallick2 dmallick2 enabled auto-merge (squash) July 29, 2025 21:25
@dmallick2 dmallick2 disabled auto-merge July 30, 2025 05:01
@dmallick2 dmallick2 enabled auto-merge (squash) July 30, 2025 05:01
@dmallick2 dmallick2 merged commit 652b251 into AliceO2Group:master Jul 30, 2025
16 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
Co-authored-by: Sawan Sawan <sawan.sawan@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Co-authored-by: Sawan Sawan <sawan.sawan@cern.ch>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Co-authored-by: Sawan Sawan <sawan.sawan@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants