[PWGLF] Improvements in photon deduplication #12242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianniliveraro
requested review from
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
maciacco,
romainschotter,
skundu692 and
smaff92
as code owners
|
O2 linter results: ❌ 210 errors, |
Please consider the following formatting changes to AliceO2Group#12242
romainschotter
approved these changes
Jul 25, 2025
maciacco
approved these changes
Jul 25, 2025
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Aug 12, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new modes for photon deduplication in the strangenessbuilder, including the use of a BDT model:
Mode 4: Selects the photon with the best BDT score (winner-takes-all approach);
Mode 5: Applies a selection based on the pointing angle (non–winner-takes-all);
Mode 6: Applies a selection based on the BDT score (non–winner-takes-all).
Local tests show no CPU or memory overhead when the BDT model is disabled, indicating that computational resource usage should remain unchanged.
Additionally, the buildV0Candidate method in strangenessBuilderHelper now also computes the V0 DCA to the primary vertex.
Tagging @ddobrigk and @romainschotter