Skip to content

Conversation

@dajones2
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 24, 2025

O2 linter results: ❌ 15 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title PWGJE: Adding outlier cut QA [PWGJE] Adding outlier cut QA Jul 24, 2025
@vkucera vkucera marked this pull request as draft July 24, 2025 17:06
@dajones2 dajones2 marked this pull request as ready for review July 28, 2025 16:41
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 7c982ed at 2025-07-29 08:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:185:240: error: could not convert '{"registry", {{"hNtrig", "number of triggers;trigger type;entries", {o2::framework::kTH1F, {{2, 0, 2}}}}, {"hSignalTriggersPtHard", "Signal triggers vs PtHard", {o2::framework::kTH1F, {{20, 0, 5}}}}, {"hReferenceTriggersPtHard", "Reference triggers vs PtHard", {o2::framework::kTH1F, {{20, 0, 5}}}}, {"hZvtxSelected", "Z vertex position;Z_{vtx};entries", {o2::framework::kTH1F, {{80, -20, 20}}}}, {"hPtTrack", "Track p_{T};p_{T};entries", {o2::framework::kTH1F, {{200, 0, 200}}}}, {"hEtaTrack", "Track #eta;#eta;entries", {o2::framework::kTH1F, {{100, -1.0e+0, 1.0e+0}}}}, {"hPhiTrack", "Track #phi;#phi;entries", {o2::framework::kTH1F, {{100, 0.0, o2::constants::math::TwoPI}}}}, {"hTrack3D", "3D tracks histogram;p_{T};#eta;#phi", {o2::framework::kTH3F, {{200, 0, 200}, {100, -1.0e+0, 1.0e+0}, {100, 0.0, o2::constants::math::TwoPI}}}}, {"hTrackPtHard", "Tracks vs pThard;#frac{p_{T}}{#hat{p}};p_{T}", {o2::framework::kTH3F, {{20, 0, 5}, {200, 0, 200}}}}, {"hPartPtHard", "Part vs pThard;#frac{p_{T}}{#hat{p}};p_{T}", {o2::framework::kTH3F, {{20, 0, 5}, {200, 0, 200}}}}, {"hPtTrackPtHard", "Track p_{T} vs #hat{p};p_{T};#frac{p_{T}}{#hat{p}}", {o2::framework::kTH2F, {{200, 0, 200}, {20, 0, 5}}}}, {"hConstituents3D", "3D constituents histogram;p_{T};#eta;#phi", {o2::framework::kTH3F, {{200, 0, 200}, {100, -1.0e+0, 1.0e+0}, {100, 0.0, o2::constants::math::TwoPI}}}}, {"hReferencePtDPhi", "jet p_{T} vs DPhi;#Delta#phi;p_{T,jet}", {o2::framework::kTH2F, {{100, 0, o2::constants::math::TwoPI}, {500, -100, 400}}}}, {"hReferencePtDPhiShifts", "rho shifts;#Delta#phi;p_{T,jet};shifts", {o2::framework::kTH3F, {{100, 0, o2::constants::math::TwoPI}, {500, -100, 400}, {20, 0.0, 2.0e+0}}}}, {"hSignalPtDPhi", "jet p_{T} vs DPhi;#Delta#phi;p_{T,jet}", {o2::framework::kTH2F, {{100, 0, o2::constants::math::TwoPI}, {500, -100, 400}}}}, {"hReferencePt", "jet p_{T};p_{T,jet};entries", {o2::framework::kTH1F, {{500, -100, 400}}}}, {"hSignalPt", "jet p_{T};p_{T,jet};entries", {o2::framework::kTH1F, {{500, -100, 400}}}}, {"hSignalTriggers", "trigger p_{T};p_{T,trig};entries", {o2::framework::kTH1F, {{150, 0, 150}}}}, {"hSignalPtHard", "jet p_{T} vs #hat{p};p_{T,jet};#frac{p_{T,trig}}{#hat{p}}", {o2::framework::kTH2F, {{500, -100, 400}, {20, 0, 5}}}}, {"hReferenceTriggers", "trigger p_{T};p_{T,trig};entries", {o2::framework::kTH1F, {{150, 0, 150}}}}, {"hReferencePtHard", "jet p_{T} vs #hat{p};p_{T,jet};#frac{p_{T,trig}}{#hat{p}}", {o2::framework::kTH2F, {{500, -100, 400}, {20, 0, 5}}}}, {"hSigEventTriggers", "N_{triggers};events", {o2::framework::kTH1F, {{10, 0, 10}}}}, {"hRefEventTriggers", "N_{triggers};events", {o2::framework::kTH1F, {{10, 0, 10}}}}, {"hJetPt", "jet p_{T};p_{T,jet};entries", {o2::framework::kTH1F, {{500, -100, 400}}}}, {"hJetEta", "jet #eta;#eta_{jet};entries", {o2::framework::kTH1F, {{100, -1.0e+0, 1.0e+0}}}}, {"hJetPhi", "jet #phi;#phi_{jet};entries", {o2::framework::kTH1F, {{100, 0.0, o2::constants::math::TwoPI}}}}, {"hJet3D", "3D jet distribution;p_{T};#eta;#phi", {o2::framework::kTH3F, {{500, -100, 400}, {100, -1.0e+0, 1.0e+0}, {100, 0.0, o2::constants::math::TwoPI}}}}, {"hTracksvsJetscomparing leading tracks and jets;p_{T,track};p_{T,jet};#hat{p}", {o2::framework::kTH3F, {{200, 0, 200}, {500, -100, 400}, {195, 5, 200}}}}, {"hPartvsJetscomparing leading particles and jets;p_{T,part};p_{T,jet};#hat{p}", {o2::framework::kTH3F, {{200, 0, 200}, {500, -100, 400}, {195, 5, 200}}}}, {"hPtPart", "Particle p_{T};p_{T};entries", {o2::framework::kTH1F, {{200, 0, 200}}}}, {"hEtaPart", "Particle #eta;#eta;entries", {o2::framework::kTH1F, {{100, -1.0e+0, 1.0e+0}}}}, {"hPhiPart", "Particle #phi;#phi;entries", {o2::framework::kTH1F, {{100, 0.0, o2::constants::math::TwoPI}}}}, {"hPart3D", "3D tracks histogram;p_{T};#eta;#phi", {o2::framework::kTH3F, {{200, 0, 200}, {100, -1.0e+0, 1.0e+0}, {100, 0.0, o2::constants::math::TwoPI}}}}, {"hPtPartPtHard", "Track p_{T} vs #hat{p};p_{T};#frac{p_{T}}{#hat{p}}", {o2::framework::kTH2F, {{200, 0, 200}, {20, 0, 5}}}}, {"hDeltaR", "#DeltaR;#DeltaR;#frac{dN_{jets}}{d#DeltaR}", {o2::framework::kTH1F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRPart", "Particle #DeltaR;#DeltaR;#frac{1}{N_{jets}}#frac{dN_{jets}}{d#DeltaR}", {o2::framework::kTH1F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpT", "jet p_{T} vs #DeltaR;p_{T,jet};#DeltaR", {o2::framework::kTH2F, {{500, -100, 400}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTPart", "Particle jet p_{T} vs #DeltaR;p_{T,jet};#DeltaR", {o2::framework::kTH2F, {{400, 0, 400}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hRhoSignal", "Signal Rho bkg;#rho;entries", {o2::framework::kTH1F, {{220, 0, 220}}}}, {"hRhoReference", "Reference Rho bkg;#rho;entries", {o2::framework::kTH1F, {{220, 0, 220}}}}, {"hRhoReferenceShift", "Testing reference shifts;#rho;shift", {o2::framework::kTH2F, {{220, 0, 220}, {20, 0.0, 2.0e+0}}}}, {"hDeltaRSignal", "#DeltaR;#DeltaR;#frac{dN_{jets}}{d#DeltaR}", {o2::framework::kTH1F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRSignalPart", "Particle #DeltaR;#DeltaR;#frac{1}{N_{jets}}#frac{dN_{jets}}{d#DeltaR}", {o2::framework::kTH1F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTSignal", "jet p_{T} vs #DeltaR;p_{T,jet};#DeltaR", {o2::framework::kTH2F, {{500, -100, 400}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTSignalPart", "Particle jet p_{T} vs #DeltaR;p_{T,jet};#DeltaR", {o2::framework::kTH2F, {{400, 0, 400}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTDPhiSignal", "jet p_{T} vs #DeltaR vs #Delta#phi;p_{T,jet};#Delta#phi;#DeltaR", {o2::framework::kTH3F, {{500, -100, 400}, {100, 0, o2::constants::math::TwoPI}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTDPhiSignalPart", "Particle jet p_{T} vs #DeltaR vs #Delta#phi;p_{T,jet};#Delta#phi;#DeltaR", {o2::framework::kTH3F, {{400, 0, 400}, {100, 0, o2::constants::math::TwoPI}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRReference", "#DeltaR;#DeltaR;#frac{dN_{jets}}{d#DeltaR}", {o2::framework::kTH1F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRPartReference", "Particle #DeltaR;#DeltaR;#frac{1}{N_{jets}}#frac{dN_{jets}}{d#DeltaR}", {o2::framework::kTH1F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTReference", "jet p_{T} vs #DeltaR;p_{T,jet};#DeltaR", {o2::framework::kTH2F, {{500, -100, 400}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTPartReference", "Particle jet p_{T} vs #DeltaR;p_{T,jet};#DeltaR", {o2::framework::kTH2F, {{400, 0, 400}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTDPhiReference", "jet p_{T} vs #DeltaR vs #Delta#phi;p_{T,jet};#Delta#phi;#DeltaR", {o2::framework::kTH3F, {{500, -100, 400}, {100, 0, o2::constants::math::TwoPI}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hDeltaRpTDPhiReferenceShifts", "testing shifts;p_{T,jet};#Delta#phi;#DeltaR;shifts", {o2::framework::kTHnSparseD, {{500, -100, 400}, {100, 0, o2::constants::math::TwoPI}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis, {20, 0.0, 2.0e+0}}}}, {"hDeltaRpTDPhiReferencePart", "jet p_{T} vs #DeltaR vs #Delta#phi;p_{T,jet};#Delta#phi;#DeltaR", {o2::framework::kTH3F, {{400, 0, 400}, {100, 0, o2::constants::math::TwoPI}, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxis}}}, {"hPtMatched", "p_{T} matching;p_{T,det};p_{T,part}", {o2::framework::kTH2F, {{500, -100, 400}, {400, 0, 400}}}}, {"hPhiMatched", "#phi matching;#phi_{det};#phi_{part}", {o2::framework::kTH2F, {{100, 0.0, o2::constants::math::TwoPI}, {100, 0.0, o2::constants::math::TwoPI}}}}, {"hDeltaRMatched", "#DeltaR matching;#DeltaR_{det};#DeltaR_{part}", {o2::framework::kTH2F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxisDet, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxisPart}}}, {"hPtMatched1d", "p_{T} matching 1d;p_{T,part}", {o2::framework::kTH1F, {{400, 0, 400}}}}, {"hDeltaRMatched1d", "#DeltaR matching 1d;#DeltaR_{part}", {o2::framework::kTH1F, {((JetHadronRecoil*)this)->JetHadronRecoil::dRAxisPart}}}, {"hPtResolution", "p_{T} resolution;p_{T,part};Relative Resolution", {o2::framework::kTH2F, {{400, 0, 400}, {1000, -5.0e+0, 5.0e+0}}}}, {"hPhiResolution", "#phi resolution;#p{T,part};Resolution", {o2::framework::kTH2F, {{400, 0, 400}, {1000, -7.0e+0, 7.0e+0}}}}, {"hDeltaRResolution", "#DeltaR Resolution;p_{T,part};Resolution", {o2::framework::kTH2F, {{400, 0, 400}, {1000, -1.4999999999999999e-1, 1.4999999999999999e-1}}}}, {"hFullMatching", "Full 6D matching;p_{T,det};p_{T,part};#phi_{det};#phi_{part};#DeltaR_{det};#DeltaR_{part}", {o2::framework::kTHnSparseD, {((JetHadronRecoil*)this)->JetHadronRecoil::ptAxisDet, ((JetHadronRecoil*)this)->JetHadronRecoil::ptAxisPart, ((JetHadronRecoil*)this)->JetHadronRecoil::phiAxisDet, ((JetHadronRecoil*)this)->JetHadronRecoil::phiAxisPart, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxisDet, ((JetHadronRecoil*)this)->JetHadronRecoil::dRAxisPart}}}}}' from '<brace-enclosed initializer list>' to 'o2::framework::HistogramRegistry'
/sw/slc9_x86-64/O2/daily-20250729-0000-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(JetHadronRecoil*&)'
ninja: build stopped: subcommand failed.

Full log here.

nzardosh
nzardosh previously approved these changes Jul 29, 2025
@nzardosh nzardosh self-requested a review July 29, 2025 15:05
@nzardosh
Copy link
Collaborator

there are conflicts that need to be resolved

@nzardosh
Copy link
Collaborator

It seems there is a build failure too

@nzardosh
Copy link
Collaborator

approved :) In general it would be good if you could confirm it builds locally before pushing

@nzardosh nzardosh enabled auto-merge (squash) July 30, 2025 12:01
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 497f893 at 2025-07-30 15:07:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:227:11: error: declaration of 'float pTHat' shadows a parameter
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:227:49: error: 'pTHatExponent' was not declared in this scope
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:377:11: error: declaration of 'float pTHat' shadows a parameter
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:377:49: error: 'pTHatExponent' was not declared in this scope
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:212:116: error: unused parameter 'pTHat' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:212:116: error: unused parameter 'pTHat' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12225-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:363:105: error: unused parameter 'pTHat' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@nzardosh nzardosh merged commit 24f8b3b into AliceO2Group:master Jul 30, 2025
12 of 13 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants