Skip to content

Conversation

@arossi81
Copy link
Contributor

…tering of tracks.

@github-actions
Copy link

github-actions bot commented Jul 18, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title adding filtering of collisions to save space and better balancing fil… [DPG] adding filtering of collisions to save space and better balancing fil… Jul 18, 2025
@alcaliva alcaliva enabled auto-merge (squash) July 18, 2025 13:57
alcaliva
alcaliva previously approved these changes Jul 18, 2025
auto-merge was automatically disabled July 18, 2025 16:10

Head branch was pushed to by a user without write access

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 4befc4c at 2025-07-18 20:33:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:264:11: error: unused variable 'zvtz' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:293:11: error: unused variable 'zvtz' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.


## sw/BUILD/84402a96b4f9fc0b50ea0f69176502293ed0c677-latest/log
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:264:11: error: unused variable 'zvtz' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:293:11: error: unused variable 'zvtz' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@arossi81
Copy link
Contributor Author

@alcaliva , @alibuild : it's not clear to me what's the error for the macOS-arm test. Could the test be rerun?

@alcaliva alcaliva enabled auto-merge (squash) July 19, 2025 16:09
alcaliva
alcaliva previously approved these changes Jul 19, 2025
@vkucera
Copy link
Collaborator

vkucera commented Jul 21, 2025

@arossi81 @alcaliva Please do not ignore the failing tests.

@arossi81
Copy link
Contributor Author

Hi @vkucera , what do you mean? The required macOS-arm test is failing w/o a reason, no log.

@vkucera
Copy link
Collaborator

vkucera commented Jul 21, 2025

Hi @vkucera , what do you mean? The required macOS-arm test is failing w/o a reason, no log.

Hi @arossi81 , I mean the other failing tests: MegaLinter and O2 linter.

auto-merge was automatically disabled July 22, 2025 08:55

Head branch was pushed to by a user without write access

@arossi81
Copy link
Contributor Author

@vkucera , @alcaliva
while waiting that the pull requests can be merged again I fixed most of the Linter and MegaLinter issues. I would prefer to not touch the remaining ones. @alcaliva , I need again your approval, thanks!

alcaliva
alcaliva previously approved these changes Jul 22, 2025
@vkucera
Copy link
Collaborator

vkucera commented Jul 22, 2025

Thanks @arossi81 for the fixes! The remaining 2 errors are trivial to fix but I understand if there is an urgency in merging the PR.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for df8a984 at 2025-07-22 13:33:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:362:41: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:252:43: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for ce48c8e at 2025-07-22 17:10:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:362:41: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/12141-slc9_x86-64/0/DPG/Tasks/ITS/filterTracks.cxx:252:43: error: comparison of integer expressions of different signedness: 'int64_t' {aka 'long int'} and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alcaliva alcaliva enabled auto-merge (squash) July 22, 2025 16:34
@alcaliva alcaliva merged commit 1e67df2 into AliceO2Group:master Jul 22, 2025
12 of 13 checks passed
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
…ng fil… (AliceO2Group#12141)

Co-authored-by: Andrea <andrea.rossicern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
…ng fil… (AliceO2Group#12141)

Co-authored-by: Andrea <andrea.rossicern.ch>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
…ng fil… (AliceO2Group#12141)

Co-authored-by: Andrea <andrea.rossicern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants