Skip to content

[Common] Revert "[Common] Improve verbose message in TableHelper" #12110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 1 commit into from
Jul 17, 2025
Merged

[Common] Revert "[Common] Improve verbose message in TableHelper" #12110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions Common/Core/TableHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,22 +79,14 @@
}
if (device.name == taskName) { // Found the mother task
int optionCounter = 0;
for (const o2::framework::ConfigParamSpec& option : device.options) {

Check failure on line 82 in Common/Core/TableHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (verbose) {
LOG(info) << " Option " << optionCounter++ << " " << option.name << " of type " << static_cast<int>(option.type) << " = '" << option.defaultValue.asString() << "'";
}
if (option.name == optName) {
value = option.defaultValue.get<ValueType>();
if (verbose) {
if constexpr (std::is_same_v<ValueType, o2::framework::LabeledArray<float>>) {
LOG(info) << " Found option '" << optName << "' a o2::framework::LabeledArray<float>";
LOG(info) << " Values: ";
for (uint32_t r = 0; r < value.rows(); r++) {
for (uint32_t c = 0; r < value.cols(); c++) {
LOG(info) << " r " << r << " c " << c << value.get(r, c);
}
}
} else {
if constexpr (!std::is_same_v<ValueType, o2::framework::LabeledArray<float>>) {
LOG(info) << " Found option '" << optName << "' with value '" << value << "'";
}
found = true;
Expand Down
Loading