Skip to content

[PWGCF,PWGHF] Add a task for p-Dplus correlations in femtodream #12102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangbiao-phy merged 45 commits into from
Aug 6, 2025
Merged

[PWGCF,PWGHF] Add a task for p-Dplus correlations in femtodream #12102

zhangbiao-phy merged 45 commits into from
Aug 6, 2025

Conversation

@Yunfan-Liu
Copy link
Contributor

@Yunfan-Liu Yunfan-Liu commented Jul 17, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 17, 2025 •
edited
Loading

O2 linter results: ❌ 62 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title add a task for p-Dplus correlations in femtodream [PWGCF,PWGHF] add a task for p-Dplus correlations in femtodream Jul 17, 2025
@alibuild alibuild mentioned this pull request Jul 17, 2025
Merged
@Yunfan-Liu
Merge pull request #24 from alibuild/alibot-cleanup-12102
7cf67bc 
Please consider the following formatting changes to AliceO2Group#12102
@Yunfan-Liu Yunfan-Liu closed this Jul 17, 2025
@Yunfan-Liu Yunfan-Liu reopened this Jul 17, 2025
@Yunfan-Liu Yunfan-Liu marked this pull request as ready for review July 17, 2025 07:24
@vkucera
Copy link
Collaborator

vkucera commented Aug 5, 2025

Please use meaningful commit messages. "Update taskCharmHadronsFemtoDream.cxx" does not tell me anything about what the commit did.

@Yunfan-Liu
Copy link
Contributor Author

Yunfan-Liu commented Aug 5, 2025

Please use meaningful commit messages. "Update taskCharmHadronsFemtoDream.cxx" does not tell me anything about what the commit did.

I am very sorry, I will write the changes as the title. I'm trying to fix the linter errors.

@alibuild alibuild mentioned this pull request Aug 5, 2025
Merged
@Yunfan-Liu Yunfan-Liu marked this pull request as ready for review August 5, 2025 11:58
@Yunfan-Liu
Copy link
Contributor Author

Yunfan-Liu commented Aug 5, 2025

Don't make a PR ready for review if it produces errors.

I fixed the linter errors from the HF part

@vkucera vkucera marked this pull request as draft August 5, 2025 12:23
@vkucera
Copy link
Collaborator

vkucera commented Aug 5, 2025

As I said before, don't make a PR ready for review if it produces errors. That includes compilation without warnings/errors.

@alibuild
Copy link
Collaborator

alibuild commented Aug 5, 2025

Error while checking build/O2Physics/o2 for 755c17d at 2025-08-05 14:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12102-slc9_x86-64/0/PWGCF/FemtoDream/Core/femtoDreamContainer.h:213:31: error: 'mP2' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/12102-slc9_x86-64/0/PWGCF/FemtoDream/Core/femtoDreamContainer.h:213:31: error: 'mP2' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/12102-slc9_x86-64/0/PWGCF/FemtoDream/Core/femtoDreamContainer.h:213:31: error: 'mP2' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/12102-slc9_x86-64/0/PWGCF/FemtoDream/Core/femtoDreamContainer.h:213:31: error: 'mP2' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/12102-slc9_x86-64/0/PWGCF/FemtoDream/Core/femtoDreamContainer.h:213:31: error: 'mP2' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/12102-slc9_x86-64/0/PWGCF/FemtoDream/Core/femtoDreamContainer.h:213:31: error: 'mP2' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@Yunfan-Liu
Fix Compilation Errors in femtoDreamContainer.h
020bc07 
use "float mP2 = 0.0;" instead of "float mP2;"
@Yunfan-Liu
Copy link
Contributor Author

Yunfan-Liu commented Aug 5, 2025

As I said before, don't make a PR ready for review if it produces errors. That includes compilation without warnings/errors.

Sorry, I didn't encounter this issue during my local compilation test. I have now fixed it.

@Yunfan-Liu Yunfan-Liu marked this pull request as ready for review August 5, 2025 12:55
@vkucera
Copy link
Collaborator

vkucera commented Aug 5, 2025

As I said before, don't make a PR ready for review if it produces errors. That includes compilation without warnings/errors.

Sorry, I didn't encounter this issue during my local compilation test. I have now fixed it.

Did you check the log for warnings?

@Yunfan-Liu
Copy link
Contributor Author

Yunfan-Liu commented Aug 5, 2025

As I said before, don't make a PR ready for review if it produces errors. That includes compilation without warnings/errors.

Sorry, I didn't encounter this issue during my local compilation test. I have now fixed it.

Did you check the log for warnings?

Since the compilation didn’t fail, I didn’t check the log. I see this warning now, and I will be more careful in the future

@zhangbiao-phy
Copy link
Collaborator

zhangbiao-phy commented Aug 5, 2025

hi @Yunfan-Liu, Thanks a lot! all looks good to me!

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) August 5, 2025 15:25
@zhangbiao-phy zhangbiao-phy merged commit 095717f into AliceO2Group:master Aug 6, 2025
13 of 15 checks passed
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Aug 12, 2025
@Yunfan-Liu @alibuild
@zhangbiao-phy @jpxrk
[PWGCF,PWGHF] Add a task for p-Dplus correlations in femtodream (Alic…
7822fe1 
…eO2Group#12102)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@Yunfan-Liu @alibuild
@zhangbiao-phy @jloemker
[PWGCF,PWGHF] Add a task for p-Dplus correlations in femtodream (Alic…
82d07e9 
…eO2Group#12102)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@Yunfan-Liu @alibuild @zhangbiao-phy
[PWGCF,PWGHF] Add a task for p-Dplus correlations in femtodream (Alic…
39db6da 
…eO2Group#12102)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lauraser lauraser lauraser approved these changes

@zhangbiao-phy zhangbiao-phy zhangbiao-phy approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yunfan-Liu @vkucera @alibuild @zhangbiao-phy @lauraser