Skip to content

[PWGEM/Dilepton] remove unnecessary Preslice #12073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsekihat merged 3 commits into from
Jul 17, 2025
Merged

[PWGEM/Dilepton] remove unnecessary Preslice #12073

dsekihat merged 3 commits into from
Jul 17, 2025
+65 −31

Conversation

@dsekihat
Copy link
Collaborator

@dsekihat dsekihat commented Jul 15, 2025 •
edited
Loading

PWGEM/Dilepton: remove unnecessary Preslice
PWGEM/Dilepton: reduce function arguments

@github-actions github-actions bot added the pwgem label Jul 15, 2025
@github-actions github-actions bot changed the title PWGEM/Dilepton: remove unnecessary Preslice [PWGEM/Dilepton] remove unnecessary Preslice Jul 15, 2025
@github-actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

O2 linter results: ❌ 163 errors, ⚠️ 0 warnings, 🔕 0 disabled

@dsekihat dsekihat enabled auto-merge (squash) July 15, 2025 19:55
alibuild
alibuild previously approved these changes Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat disabled auto-merge July 16, 2025 10:15
@dsekihat dsekihat enabled auto-merge (squash) July 16, 2025 10:45
alibuild
alibuild previously approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild
Copy link
Collaborator

alibuild commented Jul 17, 2025

Error while checking build/O2Physics/o2 for 863e08d at 2025-07-17 04:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:388:106: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:409:108: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:439:117: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:464:119: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:496:139: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:522:141: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.


## sw/BUILD/0443743bc134371bd173fa00bff0b41eca160616-latest/log
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:388:106: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:409:108: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:439:117: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:464:119: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:496:139: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/12073-slc9_x86-64/0/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:522:141: error: unused parameter 'mfttracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@dsekihat dsekihat disabled auto-merge July 17, 2025 10:12
@dsekihat dsekihat enabled auto-merge (squash) July 17, 2025 10:12
alibuild
alibuild approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit 80c80ac into AliceO2Group:master Jul 17, 2025
11 of 12 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@dsekihat
[PWGEM/Dilepton] remove unnecessary Preslice (AliceO2Group#12073)
1cffe40
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@dsekihat
[PWGEM/Dilepton] remove unnecessary Preslice (AliceO2Group#12073)
3ca0f3d
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@dsekihat @vojmach
[PWGEM/Dilepton] remove unnecessary Preslice (AliceO2Group#12073)
08cae11
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@dsekihat @jloemker
[PWGEM/Dilepton] remove unnecessary Preslice (AliceO2Group#12073)
d508743
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
@dsekihat
[PWGEM/Dilepton] remove unnecessary Preslice (AliceO2Group#12073)
792dae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@ivorobye ivorobye Awaiting requested review from ivorobye ivorobye is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

datamodel pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsekihat @alibuild