Skip to content

Conversation

@sashingo
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pwghf PWG-HF label Jul 15, 2025
@github-actions github-actions bot changed the title included charge info in histogrmas for Z measurement [PWGHF] included charge info in histogrmas for Z measurement Jul 15, 2025
@github-actions
Copy link

github-actions bot commented Jul 15, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

@sashingo
Copy link
Contributor Author

Hi Vit and all, if there is no further comments / suggestions, could you approve the commit ?

@vkucera
Copy link
Collaborator

vkucera commented Jul 16, 2025

Hi @sashingo , I just spotted that you use TH1F histograms for counters. This can truncate your bin counts if you hit the float precision limit. Consider using TH1D instead wherever the bin content can be larger than 2^24.

@sashingo
Copy link
Contributor Author

Hi Vit, thank you for the information.
I changed histograms of event counts from TH1F to TH1D to avoid the issue.

@vkucera vkucera changed the title [PWGHF] included charge info in histogrmas for Z measurement [PWGHF] Z task: Add charge in histograms Jul 16, 2025
@vkucera vkucera changed the title [PWGHF] Z task: Add charge in histograms [PWGHF/HFL] Z task: Add charge in histograms Jul 16, 2025
@vkucera vkucera enabled auto-merge (squash) July 16, 2025 13:21
@vkucera vkucera merged commit b342dc8 into AliceO2Group:master Jul 17, 2025
17 of 18 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants